Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add source id isolation for reverse etl #3496

Merged
merged 15 commits into from
Sep 11, 2024
Merged

Conversation

koladilip
Copy link
Contributor

@koladilip koladilip commented Jun 24, 2024

What are the changes introduced in this PR?

This is for rETL connections for supporting job run level isolation

What is the related Linear task?

Resolves INT-2299, Resolves INT-2300, Resolves INT-2519

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@koladilip koladilip requested a review from utsabc June 24, 2024 05:33
@koladilip koladilip requested review from sivashanmukh and a team as code owners June 24, 2024 05:33
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (fa98d66) to head (6fdc183).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3496      +/-   ##
===========================================
+ Coverage    88.62%   88.64%   +0.01%     
===========================================
  Files          592      594       +2     
  Lines        32198    32352     +154     
  Branches      7655     7697      +42     
===========================================
+ Hits         28537    28679     +142     
- Misses        3338     3350      +12     
  Partials       323      323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip koladilip requested a review from a team as a code owner July 3, 2024 09:35
@koladilip koladilip requested a review from aashishmalik July 3, 2024 09:35
@koladilip koladilip changed the title feat: add job run id level isolation feat: add source id isolation for reverse etl Jul 3, 2024
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@koladilip
Copy link
Contributor Author

closing for #3675

@koladilip koladilip closed this Sep 3, 2024
@koladilip koladilip reopened this Sep 10, 2024
@koladilip koladilip requested a review from ItsSudip September 11, 2024 06:02
krishna2020
krishna2020 previously approved these changes Sep 11, 2024
Copy link

@koladilip koladilip merged commit b4f4dd1 into develop Sep 11, 2024
27 checks passed
@koladilip koladilip deleted the feat.many-to-one branch September 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants