Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cache dns resolution in node #3495

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Conversation

Jayachand
Copy link
Collaborator

@Jayachand Jayachand commented Jun 22, 2024

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

fixes DAT-466

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Jayachand Jayachand requested review from a team as code owners June 22, 2024 17:21
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (02ad46e) to head (e60c6ea).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/util/utils.js 72.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3495      +/-   ##
===========================================
- Coverage    88.13%   88.12%   -0.02%     
===========================================
  Files          585      585              
  Lines        31566    31583      +17     
  Branches      7573     7579       +6     
===========================================
+ Hits         27821    27832      +11     
- Misses        3429     3434       +5     
- Partials       316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kanishkkatara
kanishkkatara previously approved these changes Jul 3, 2024
src/util/utils.js Outdated Show resolved Hide resolved
src/util/utils.js Outdated Show resolved Hide resolved
src/util/utils.js Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jul 9, 2024

@Jayachand Jayachand merged commit 9b82931 into develop Jul 10, 2024
17 checks passed
@Jayachand Jayachand deleted the chore.dns-cache-resolution branch July 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants