Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: filtered logging and log for all destinations #3484

Merged
merged 19 commits into from
Jul 2, 2024

Conversation

sanpj2292
Copy link
Contributor

What are the changes introduced in this PR?

  • Logging of request and response would be done when
    • LOG_LEVEL=warn and (LOG_DEST_IDS="d1,d2" || LOG_WSP_IDS="w1,w2")
  • This change will log all request-response combinations for all destinations(that have intermediate API calls) and also use one of http(Post|Put|Delete|Patch|Get|Send)

What is the related Linear task?

Resolves INT-2153

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners June 19, 2024 17:53
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (3194638) to head (89d0224).
Report is 6 commits behind head on develop.

Files Patch % Lines
src/adapters/network.js 97.87% 1 Missing ⚠️
src/util/logger.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3484      +/-   ##
===========================================
+ Coverage    88.05%   88.07%   +0.01%     
===========================================
  Files          584      585       +1     
  Lines        31588    31563      -25     
  Branches      7539     7564      +25     
===========================================
- Hits         27816    27798      -18     
+ Misses        3423     3416       -7     
  Partials       349      349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/logger.js Outdated Show resolved Hide resolved
krishna2020
krishna2020 previously approved these changes Jun 21, 2024
@sanpj2292 sanpj2292 requested a review from a team as a code owner June 24, 2024 05:22
ItsSudip
ItsSudip previously approved these changes Jun 24, 2024
src/adapters/network.js Outdated Show resolved Hide resolved
src/adapters/network.js Outdated Show resolved Hide resolved
@sanpj2292 sanpj2292 requested a review from ItsSudip June 26, 2024 05:41
* chore: filtered logging and log for all destinations refactor

Signed-off-by: Sai Sankeerth <[email protected]>

* chore: remove unnecessary comments

* chore: rename variable

---------

Signed-off-by: Sai Sankeerth <[email protected]>
Co-authored-by: Sai Sankeerth <[email protected]>
Copy link

sonarqubecloud bot commented Jul 2, 2024

@koladilip
Copy link
Contributor

I am assuming some of the logs removed are no longer needed

@sanpj2292
Copy link
Contributor Author

I am assuming some of the logs removed are no longer needed

Yes. They are not needed now.

@sanpj2292 sanpj2292 merged commit aa0ea60 into develop Jul 2, 2024
17 checks passed
@sanpj2292 sanpj2292 deleted the chore.log-filter branch July 2, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants