-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: filtered logging and log for all destinations #3484
Conversation
Signed-off-by: Sai Sankeerth <[email protected]>
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3484/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3484 +/- ##
===========================================
+ Coverage 88.05% 88.07% +0.01%
===========================================
Files 584 585 +1
Lines 31588 31563 -25
Branches 7539 7564 +25
===========================================
- Hits 27816 27798 -18
+ Misses 3423 3416 -7
Partials 349 349 ☔ View full report in Codecov by Sentry. |
src/v0/destinations/google_adwords_offline_conversions/networkHandler.js
Show resolved
Hide resolved
Signed-off-by: Sai Sankeerth <[email protected]>
- add test-cases
Co-authored-by: Sudip Paul <[email protected]>
* chore: filtered logging and log for all destinations refactor Signed-off-by: Sai Sankeerth <[email protected]> * chore: remove unnecessary comments * chore: rename variable --------- Signed-off-by: Sai Sankeerth <[email protected]> Co-authored-by: Sai Sankeerth <[email protected]>
Quality Gate passedIssues Measures |
I am assuming some of the logs removed are no longer needed |
Yes. They are not needed now. |
What are the changes introduced in this PR?
http(Post|Put|Delete|Patch|Get|Send)
What is the related Linear task?
Resolves INT-2153
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.