Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: onboard plugin framework #3481

Closed
wants to merge 4 commits into from
Closed

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Jun 19, 2024

What are the changes introduced in this PR?

Ref Design Doc: https://www.notion.so/rudderstacks/Integration-Plugin-26ff1465dd9b44f1b3a80239651152a5

This PR introduces onboarding of plugin integration framework to transformer, we take the approach of onboarding a new service aligning to the predefined interface to dictate the service structure

Major Piece of event order orchestration for transformer <> server contract lie in pluginAdapter.ts which after passing the events to integration plugin and handles the consistent structuring for responding back to outer layer

The pluginAdapter uses integration-store to get integration-plugin to do either processor/router transformer

Further we updated type definitions referencing from integrations-lib which acts as a common library

@utsabc utsabc requested review from a team and sivashanmukh as code owners June 19, 2024 10:32
@utsabc utsabc requested review from sanpj2292 and sandeepdsvs June 19, 2024 10:32
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 81.09756% with 31 lines in your changes missing coverage. Please review.

Project coverage is 88.02%. Comparing base (86c6ab4) to head (38be6cf).
Report is 217 commits behind head on develop.

Files with missing lines Patch % Lines
src/services/destination/pluginIntegration.ts 12.12% 29 Missing ⚠️
src/helpers/serviceSelector.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3481      +/-   ##
===========================================
- Coverage    88.14%   88.02%   -0.13%     
===========================================
  Files          577      579       +2     
  Lines        31197    31368     +171     
  Branches      7442     7451       +9     
===========================================
+ Hits         27500    27613     +113     
- Misses        3363     3445      +82     
+ Partials       334      310      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip
Copy link
Contributor

@utsabc update it once, conflicts or there

Copy link

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants