Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean unnecessary metrics #3475

Merged
merged 3 commits into from
Jun 19, 2024
Merged

chore: clean unnecessary metrics #3475

merged 3 commits into from
Jun 19, 2024

Conversation

sanpj2292
Copy link
Contributor

What are the changes introduced in this PR?

Cleaned up metrics that are not being used

What is the related Linear task?

Resolves INT-2082

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Signed-off-by: Sai Sankeerth <[email protected]>
@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners June 18, 2024 12:12
@sanpj2292 sanpj2292 requested review from utsabc and Gauravudia June 18, 2024 12:12
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (ca5568e) to head (f7cf56c).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3475      +/-   ##
===========================================
+ Coverage    88.03%   88.06%   +0.03%     
===========================================
  Files          574      577       +3     
  Lines        31056    31149      +93     
  Branches      7410     7426      +16     
===========================================
+ Hits         27340    27432      +92     
- Misses        3405     3407       +2     
+ Partials       311      310       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

utsabc
utsabc previously approved these changes Jun 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sanpj2292 sanpj2292 merged commit 20020af into develop Jun 19, 2024
17 checks passed
@sanpj2292 sanpj2292 deleted the chore.clean-up-stats branch June 19, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants