Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard closeCRM source #3467

Merged
merged 5 commits into from
Jun 24, 2024
Merged

feat: onboard closeCRM source #3467

merged 5 commits into from
Jun 24, 2024

Conversation

manish339k
Copy link
Contributor

What are the changes introduced in this PR?

Onboarding source closeCRM.

What is the related Linear task?

Resolves INT-1665

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@manish339k manish339k requested review from sivashanmukh and a team as code owners June 17, 2024 06:32
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (3aee494) to head (91782ee).
Report is 39 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3467      +/-   ##
===========================================
+ Coverage    88.00%   88.07%   +0.07%     
===========================================
  Files          572      579       +7     
  Lines        30910    31233     +323     
  Branches      7385     7442      +57     
===========================================
+ Hits         27202    27509     +307     
+ Misses        3398     3386      -12     
- Partials       310      338      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shrouti1507 shrouti1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the practiced style of adding test cases for sources

Copy link

@manish339k manish339k merged commit bba1a3b into develop Jun 24, 2024
17 checks passed
@manish339k manish339k deleted the feat.closeCRM branch June 24, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants