Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move gainsight_px from myaxios to httpget,put and post #3464

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

ItsSudip
Copy link
Member

What are the changes introduced in this PR?

Updating HTTP module from myaxios to http.

What is the related Linear task?

Resolves INT-1905

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested a review from a team as a code owner June 14, 2024 12:05
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (17179db) to head (9649dd3).
Report is 16 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/gainsight_px/util.js 68.75% 4 Missing and 1 partial ⚠️
src/v0/destinations/gainsight_px/transform.js 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3464      +/-   ##
===========================================
+ Coverage    88.48%   88.51%   +0.02%     
===========================================
  Files          584      584              
  Lines        31775    31759      -16     
  Branches      7567     7563       -4     
===========================================
- Hits         28116    28111       -5     
- Misses        3335     3356      +21     
+ Partials       324      292      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Copy link

sonarqubecloud bot commented Aug 5, 2024

@sanpj2292 sanpj2292 merged commit 98e9b00 into develop Aug 5, 2024
14 of 15 checks passed
@sanpj2292 sanpj2292 deleted the chore.update-gainsight_px-axios-handler branch August 5, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants