Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard new custom destination: wunderkind #3456

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Jun 12, 2024

What are the changes introduced in this PR?

Onboard new custom destination: wunderkind

What is the related Linear task?

Resolves INT-2279

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (3194638) to head (0369a25).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3456      +/-   ##
===========================================
+ Coverage    88.05%   88.07%   +0.01%     
===========================================
  Files          584      585       +1     
  Lines        31588    31565      -23     
  Branches      7539     7569      +30     
===========================================
- Hits         27816    27802      -14     
- Misses        3423     3443      +20     
+ Partials       349      320      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia marked this pull request as ready for review July 2, 2024 04:43
@Gauravudia Gauravudia requested a review from a team as a code owner July 2, 2024 04:43
@Gauravudia Gauravudia requested review from utsabc and ItsSudip July 2, 2024 04:43
@Gauravudia Gauravudia marked this pull request as draft July 2, 2024 04:44
@Gauravudia Gauravudia self-assigned this Jul 3, 2024
@Gauravudia Gauravudia marked this pull request as ready for review July 3, 2024 09:35
@Gauravudia Gauravudia requested review from sivashanmukh and a team as code owners July 3, 2024 09:35
Copy link

sonarqubecloud bot commented Jul 5, 2024

@Gauravudia Gauravudia merged commit 7f49a01 into develop Jul 5, 2024
16 of 17 checks passed
@Gauravudia Gauravudia deleted the feat.wunderkind branch July 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants