Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tags to a company in intercom #3434

Merged
merged 10 commits into from
Jun 19, 2024
Merged

Conversation

manish339k
Copy link
Contributor

What are the changes introduced in this PR?

This PR adds a feature in intercom destination. It enables to add tags to a company in group call.

What is the related Linear task?

Resolves INT-2162

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@manish339k manish339k requested a review from a team as a code owner June 3, 2024 05:17
@manish339k manish339k changed the title feat: add tags to a company feat: add tags to a company in intercom Jun 3, 2024
@manish339k manish339k requested review from sivashanmukh and a team as code owners June 10, 2024 04:31
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (ca5568e) to head (13b70d6).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3434      +/-   ##
===========================================
+ Coverage    88.03%   88.08%   +0.05%     
===========================================
  Files          574      577       +3     
  Lines        31056    31198     +142     
  Branches      7410     7436      +26     
===========================================
+ Hits         27340    27481     +141     
+ Misses        3405     3379      -26     
- Partials       311      338      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/cdk/v2/destinations/intercom/utils.js Outdated Show resolved Hide resolved
src/cdk/v2/destinations/intercom/utils.js Outdated Show resolved Hide resolved
src/cdk/v2/destinations/intercom/utils.js Outdated Show resolved Hide resolved
shrouti1507
shrouti1507 previously approved these changes Jun 14, 2024
@utsabc
Copy link
Member

utsabc commented Jun 17, 2024

The three test cases have same success criteria and same description can you please clarify the scnearios>

Copy link

@manish339k manish339k merged commit dc8eae2 into develop Jun 19, 2024
17 checks passed
@manish339k manish339k deleted the feat.intercom-add-tags branch June 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants