Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request_ip as fallback for mixpanel group call #3421

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented May 28, 2024

What are the changes introduced in this PR?

What is the related Linear task?

Resolves INT-1978

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Gauravudia Gauravudia requested a review from a team as a code owner May 28, 2024 05:53
@Gauravudia Gauravudia requested review from chandumlg and shrouti1507 and removed request for a team May 28, 2024 05:53
@Gauravudia Gauravudia changed the title feat: add request_ip as fallback for mixpanel feat: add request_ip as fallback for mixpanel group call May 28, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (cd0b81b) to head (e125ad2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3421      +/-   ##
===========================================
+ Coverage    88.01%   88.02%   +0.01%     
===========================================
  Files          569      570       +1     
  Lines        30634    30773     +139     
  Branches      7323     7351      +28     
===========================================
+ Hits         26961    27089     +128     
- Misses        3366     3377      +11     
  Partials       307      307              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shrouti1507
shrouti1507 previously approved these changes May 28, 2024
@Gauravudia Gauravudia changed the base branch from release/v1.68.0 to develop May 28, 2024 06:10
@Gauravudia Gauravudia dismissed shrouti1507’s stale review May 28, 2024 06:10

The base branch was changed.

@Gauravudia Gauravudia requested review from a team and sivashanmukh as code owners May 28, 2024 06:10
@Gauravudia Gauravudia requested a review from shrouti1507 June 6, 2024 05:06
Copy link

sonarqubecloud bot commented Jun 6, 2024

@Gauravudia Gauravudia merged commit a73ab75 into develop Jun 6, 2024
16 checks passed
@Gauravudia Gauravudia deleted the feat.mixpanel.group.ip branch June 6, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants