Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added credentials to javascript transformations #3408

Merged

Conversation

kanishkkatara
Copy link
Contributor

What are the changes introduced in this PR?

Added credentials to javascript transformations

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@kanishkkatara kanishkkatara requested review from a team and sivashanmukh as code owners May 23, 2024 10:05
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (136ca64) to head (d655fd1).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/services/userTransform.ts 16.66% 5 Missing ⚠️
src/util/ivmFactory.js 76.92% 3 Missing ⚠️
src/controllers/userTransform.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3408      +/-   ##
===========================================
- Coverage    88.06%   88.05%   -0.02%     
===========================================
  Files          577      577              
  Lines        31148    31164      +16     
  Branches      7428     7430       +2     
===========================================
+ Hits         27431    27440       +9     
- Misses        3379     3414      +35     
+ Partials       338      310      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhimanyubabbar
Copy link
Contributor

Small nit, given your branch is feature, let's start using feat as that's more widely used conventional commit semantic. Also change the heading of the PR to be then feat and not chore.

@kanishkkatara
Copy link
Contributor Author

Small nit, given your branch is feature, let's start using feat as that's more widely used conventional commit semantic. Also change the heading of the PR to be then feat and not chore.

This branch name is auto generated from linear to link the github PRs to linear tasks. Lets see if we can do something about it.

src/types/index.ts Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
test/__tests__/user_transformation.test.js Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
Jayachand
Jayachand previously approved these changes Jun 18, 2024
Jayachand
Jayachand previously approved these changes Jun 19, 2024
src/util/customTransformer.js Outdated Show resolved Hide resolved
src/controllers/userTransform.ts Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
src/util/ivmFactory.js Outdated Show resolved Hide resolved
test/__tests__/user_transformation.test.js Outdated Show resolved Hide resolved
test/__tests__/user_transformation.test.js Outdated Show resolved Hide resolved
test/__tests__/user_transformation.test.js Outdated Show resolved Hide resolved
test/__tests__/user_transformation.test.js Outdated Show resolved Hide resolved
test/__tests__/user_transformation.test.js Outdated Show resolved Hide resolved
Copy link

@kanishkkatara kanishkkatara merged commit e5887e7 into develop Jun 19, 2024
17 checks passed
@kanishkkatara kanishkkatara deleted the feature/dat-1207-javascript-transformation-changes branch June 19, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants