Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardise hashing for all CAPI integrations #3379

Merged
merged 3 commits into from
May 22, 2024

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented May 16, 2024

What are the changes introduced in this PR?

Standardise hashing for all CAPI integrations.
By standardise we mean to do trimming of strings before hashing them so that they can be properly used in downstream conversions destinations.
List of integrations involved in this:

  1. Pinterest
  2. Reddit
  3. Google ads enhanced conversions
  4. Google ads offline conversions
  5. Impact
  6. Facebook
  7. Facebook conversions

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2127

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@anantjain45823 anantjain45823 self-assigned this May 16, 2024
@anantjain45823 anantjain45823 requested review from a team and sivashanmukh as code owners May 16, 2024 12:19
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.01%. Comparing base (6fa89e3) to head (659597b).
Report is 6 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/impact/transform.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3379   +/-   ##
========================================
  Coverage    88.01%   88.01%           
========================================
  Files          565      565           
  Lines        30443    30443           
  Branches      7282     7282           
========================================
  Hits         26793    26793           
  Misses        3347     3347           
  Partials       303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anantjain45823 anantjain45823 force-pushed the fix.capiHashingStandardisation branch from 3a84b8d to 0c574d7 Compare May 21, 2024 07:23
Copy link

@anantjain45823 anantjain45823 requested a review from utsabc May 22, 2024 07:02
@anantjain45823 anantjain45823 merged commit c249a69 into develop May 22, 2024
17 checks passed
@anantjain45823 anantjain45823 deleted the fix.capiHashingStandardisation branch May 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants