Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth0 error handling for missing userId #3334

Merged
merged 3 commits into from
May 6, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented May 2, 2024

What are the changes introduced in this PR?

  • Removing this user_id required check for auth0 source.
  • Auth0 source does not always sends user_id for each request. In case of failed logins with bad email addresses, user_id will be empty and there is no other relevant field that we could map with anonymousId
  • Generate anonymousId for auth0 source.
  • Refactor and use component testcases

What is the related Linear task?

Resolves INT-2065

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Gauravudia Gauravudia self-assigned this May 2, 2024
@Gauravudia Gauravudia requested review from a team as code owners May 2, 2024 10:14
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (129a0a1) to head (eb5d9e8).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           hotfix/May.6th    #3334       +/-   ##
===================================================
+ Coverage                0   87.87%   +87.87%     
===================================================
  Files                   0      558      +558     
  Lines                   0    30063    +30063     
  Branches                0     7194     +7194     
===================================================
+ Hits                    0    26417    +26417     
- Misses                  0     3343     +3343     
- Partials                0      303      +303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia marked this pull request as draft May 2, 2024 10:38
@Gauravudia Gauravudia changed the title fix: auth0 error handling fix: auth0 error handling for missing userId May 3, 2024
@Gauravudia Gauravudia marked this pull request as ready for review May 3, 2024 10:06
@Gauravudia Gauravudia requested review from sivashanmukh and a team as code owners May 3, 2024 10:06
@Gauravudia Gauravudia changed the base branch from develop to hotfix/May.6th May 6, 2024 04:59
Copy link

sonarqubecloud bot commented May 6, 2024

@Gauravudia Gauravudia merged commit d2cce77 into hotfix/May.6th May 6, 2024
16 checks passed
@Gauravudia Gauravudia deleted the fix.auth0-source branch May 6, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants