Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: openfaas pro reconcile fn over 1 dot 62 #3331

Closed

Conversation

abhimanyubabbar
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

@abhimanyubabbar abhimanyubabbar changed the title Chore/openfaas pro reconcile fn over 1 dot 62 chore: openfaas pro reconcile fn over 1 dot 62 Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.86%. Comparing base (adb5751) to head (88ce9b7).
Report is 76 commits behind head on develop.

Files Patch % Lines
src/util/openfaas/index.js 91.42% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3331   +/-   ##
========================================
  Coverage    87.86%   87.86%           
========================================
  Files          556      558    +2     
  Lines        29996    30074   +78     
  Branches      7172     7197   +25     
========================================
+ Hits         26356    26425   +69     
- Misses        3336     3345    +9     
  Partials       304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@psrikanth88 psrikanth88 deleted the chore/openfaas-pro-reconcile-fn-over-1-dot-62 branch July 31, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants