Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: algolia add validation for currency fields #3329

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Apr 30, 2024

What are the changes introduced in this PR?

ref: https://www.algolia.com/doc/rest-api/insights/#method-param-objectdata-2:~:text=currency-,%23,currency%20as%20ISO%2D4217%20currency%20code%2C%20such%20as%20USD%20or%20EUR.,-ObjectData

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested a review from ItsSudip April 30, 2024 10:44
@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners April 30, 2024 10:44
@shrouti1507 shrouti1507 requested review from krishna2020 and removed request for a team April 30, 2024 10:44
@shrouti1507 shrouti1507 self-assigned this Apr 30, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (1701005) to head (158cd84).

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.64.0    #3329   +/-   ##
================================================
  Coverage            87.87%   87.87%           
================================================
  Files                  558      558           
  Lines                30058    30066    +8     
  Branches              7193     7198    +5     
================================================
+ Hits                 26412    26420    +8     
+ Misses                3343     3315   -28     
- Partials               303      331   +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@shrouti1507 shrouti1507 merged commit ce9f5db into release/v1.64.0 Apr 30, 2024
16 checks passed
@shrouti1507 shrouti1507 deleted the fix.algolia-validation branch April 30, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants