Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple event mappings in ortto #3324

Closed
wants to merge 1 commit into from

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Apr 29, 2024

What are the changes introduced in this PR?

The logic to check for multiple mappings was not working properly.
When there were multiple mappings, due to an issue in logic it was picking only the last mapping by default even though the event points to an earlier mapping(as per array index)

What is the related Linear task?

Resolves INT-2069

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners April 29, 2024 12:52
@sanpj2292 sanpj2292 self-assigned this Apr 29, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (5402b21) to head (658dfe1).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3324      +/-   ##
===========================================
- Coverage    87.86%   87.86%   -0.01%     
===========================================
  Files          556      558       +2     
  Lines        29996    30045      +49     
  Branches      7172     7191      +19     
===========================================
+ Hits         26356    26399      +43     
+ Misses        3336     3315      -21     
- Partials       304      331      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 changed the base branch from develop to hotfix/May.6th May 6, 2024 04:30
@sanpj2292 sanpj2292 closed this May 6, 2024
@sanpj2292 sanpj2292 deleted the fix.ortto-multiple-evt-mappings branch May 6, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants