-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard emersys destination #3318
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3318/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3318 +/- ##
===========================================
+ Coverage 87.84% 87.97% +0.12%
===========================================
Files 558 565 +7
Lines 30074 30428 +354
Branches 7198 7279 +81
===========================================
+ Hits 26419 26769 +350
- Misses 3352 3356 +4
Partials 303 303 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can we add respective doc like error code docs link at concerned places
Have we verified the security hotspot is not dangerous and if yes can we close put some comment for the same ? |
yes, but emarsys has already provided an auth function : https://dev.emarsys.com/docs/core-api-reference/b3c3a1eba8515-authentication |
305e231
Quality Gate failedFailed conditions |
feat: onboard emersys destination (#3318) --------- Co-authored-by: Dilip Kola <[email protected]> Co-authored-by: Shrouti Gangopadhyay <[email protected]>
What are the changes introduced in this PR?
Identify call : https://dev.emarsys.com/docs/core-api-reference/f8ljhut3ac2i1-update-contacts
Group call : https://dev.emarsys.com/docs/core-api-reference/1m0m70hy3tuov-add-contacts-to-a-contact-list
Track call : https://dev.emarsys.com/docs/core-api-reference/fl0xx6rwfbwqb-trigger-an-external-event
What is the related Linear task?
Resolves INT-1598
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.