Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard emersys destination #3318

Merged
merged 27 commits into from
May 13, 2024
Merged

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Apr 26, 2024

What are the changes introduced in this PR?

Identify call : https://dev.emarsys.com/docs/core-api-reference/f8ljhut3ac2i1-update-contacts
Group call : https://dev.emarsys.com/docs/core-api-reference/1m0m70hy3tuov-add-contacts-to-a-contact-list
Track call : https://dev.emarsys.com/docs/core-api-reference/fl0xx6rwfbwqb-trigger-an-external-event

What is the related Linear task?

Resolves INT-1598

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested a review from a team as a code owner April 26, 2024 15:59
@shrouti1507 shrouti1507 marked this pull request as draft April 26, 2024 15:59
@shrouti1507 shrouti1507 self-assigned this Apr 26, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 96.19772% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 87.97%. Comparing base (ea655bf) to head (305e231).
Report is 172 commits behind head on develop.

Files Patch % Lines
src/cdk/v2/destinations/emarsys/utils.js 95.40% 8 Missing ⚠️
src/v0/destinations/emarsys/deleteUsers.js 96.66% 1 Missing ⚠️
src/v1/destinations/emarsys/networkHandler.js 97.91% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3318      +/-   ##
===========================================
+ Coverage    87.84%   87.97%   +0.12%     
===========================================
  Files          558      565       +7     
  Lines        30074    30428     +354     
  Branches      7198     7279      +81     
===========================================
+ Hits         26419    26769     +350     
- Misses        3352     3356       +4     
  Partials       303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 shrouti1507 marked this pull request as ready for review May 7, 2024 05:28
@shrouti1507 shrouti1507 requested review from sivashanmukh and a team as code owners May 7, 2024 05:28
Copy link
Contributor

@anantjain45823 anantjain45823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can we add respective doc like error code docs link at concerned places

@anantjain45823
Copy link
Contributor

Have we verified the security hotspot is not dangerous and if yes can we close put some comment for the same ?

anantjain45823
anantjain45823 previously approved these changes May 10, 2024
@shrouti1507
Copy link
Contributor Author

Have we verified the security hotspot is not dangerous and if yes can we close put some comment for the same ?

yes, but emarsys has already provided an auth function : https://dev.emarsys.com/docs/core-api-reference/b3c3a1eba8515-authentication

Gauravudia
Gauravudia previously approved these changes May 11, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@shrouti1507 shrouti1507 changed the base branch from develop to release/v1.66.0 May 13, 2024 10:15
@shrouti1507 shrouti1507 changed the base branch from release/v1.66.0 to feat.emarsys-onboard May 13, 2024 10:21
@shrouti1507 shrouti1507 merged commit 3f9ed30 into feat.emarsys-onboard May 13, 2024
17 of 18 checks passed
@shrouti1507 shrouti1507 deleted the feat.emersys branch May 13, 2024 10:22
shrouti1507 added a commit that referenced this pull request May 13, 2024
feat: onboard emersys destination  (#3318)

---------

Co-authored-by: Dilip Kola <[email protected]>
Co-authored-by: Shrouti Gangopadhyay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants