Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added reconcile fn for openfaas pods #3309

Closed
wants to merge 1 commit into from

Conversation

abhimanyubabbar
Copy link
Contributor

@abhimanyubabbar abhimanyubabbar commented Apr 24, 2024

What are the changes introduced in this PR?

We are introducing a new reconcile step before we execute the fn first time from the perspective of user transformation service. This is done to sync the latest state of ut service to the openfaas-fn pods. Once the function gets added in the cache, we stop the reconciliation step and assume the function is up-to-date as the only way it could be added effectively in cache is when it was reconciled successfully.

What is the related Linear task?

Resolves DAT-1123

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (6fa89e3) to head (e7f8996).
Report is 330 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/openfaas/index.js 91.66% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3309      +/-   ##
===========================================
- Coverage    88.01%   88.01%   -0.01%     
===========================================
  Files          565      569       +4     
  Lines        30443    30634     +191     
  Branches      7282     7323      +41     
===========================================
+ Hits         26793    26961     +168     
- Misses        3347     3366      +19     
- Partials       303      307       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhimanyubabbar abhimanyubabbar requested review from sivashanmukh and a team as code owners April 30, 2024 14:18
@abhimanyubabbar abhimanyubabbar force-pushed the chore/openfaas-pro-reconcile-fn branch from b25602b to f5ec07e Compare April 30, 2024 17:56
@abhimanyubabbar abhimanyubabbar force-pushed the chore/openfaas-pro-reconcile-fn branch from 485a345 to 102b58c Compare May 21, 2024 09:51
Jayachand
Jayachand previously approved these changes May 27, 2024
Jayachand
Jayachand previously approved these changes May 28, 2024
Copy link

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@psrikanth88
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@psrikanth88 psrikanth88 added Stale and removed Stale labels Jul 31, 2024
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@devops-github-rudderstack devops-github-rudderstack deleted the chore/openfaas-pro-reconcile-fn branch August 29, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants