Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move hubspot to transformer proxy to enable partial batch handling #3308

Merged
merged 32 commits into from
Aug 12, 2024

Conversation

ItsSudip
Copy link
Member

What are the changes introduced in this PR?

With this PR we are introducing partial failure handling for Hubspot. Though Hubspot doesn't return any partial failures it discards the entire batch. So we are using dontBatch flag to process the events in isolation in the time of error.

What is the related Linear task?

Resolves INT-1746

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested review from sivashanmukh and a team as code owners April 24, 2024 13:16
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 94.50549% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (hotfix/12082024@0a9b681). Learn more about missing BASE report.

Files Patch % Lines
src/v1/destinations/hs/networkHandler.ts 91.66% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             hotfix/12082024    #3308   +/-   ##
==================================================
  Coverage                   ?   88.54%           
==================================================
  Files                      ?      585           
  Lines                      ?    31852           
  Branches                   ?     7585           
==================================================
  Hits                       ?    28203           
  Misses                     ?     3357           
  Partials                   ?      292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
@ItsSudip ItsSudip requested a review from a team as a code owner May 24, 2024 03:26
@ItsSudip ItsSudip requested a review from shrouti1507 May 24, 2024 03:26
@ItsSudip ItsSudip requested a review from utsabc May 24, 2024 05:08
anantjain45823
anantjain45823 previously approved these changes May 27, 2024
Copy link
Contributor

@anantjain45823 anantjain45823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
src/v1/destinations/hs/networkHandler.js Outdated Show resolved Hide resolved
@utsabc utsabc changed the base branch from develop to hotfix/12082024 August 12, 2024 06:52
Copy link

@ItsSudip ItsSudip merged commit 8450021 into hotfix/12082024 Aug 12, 2024
14 of 15 checks passed
@ItsSudip ItsSudip deleted the feat.hs-handle-partial-error branch August 12, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants