Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding custom properties to awin product level tracking #3303

Closed
wants to merge 2 commits into from

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Apr 22, 2024

What are the changes introduced in this PR?

We were not supporting custom parameters in product level tracking. ref : https://wiki.awin.com/index.php/Advertiser_Tracking_Guide/Product_Level_Tracking#PLT_Via_Conversion_Pixel
Hence we added support for that

What is the related Linear task?

Resolves INT-1757

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 added the enhancement New feature or request label Apr 22, 2024
@shrouti1507 shrouti1507 self-assigned this Apr 22, 2024
@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners April 22, 2024 16:01
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (adb5751) to head (dba93fc).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3303      +/-   ##
===========================================
+ Coverage    87.86%   87.88%   +0.02%     
===========================================
  Files          556      556              
  Lines        29996    30006      +10     
  Branches      7172     7172              
===========================================
+ Hits         26356    26371      +15     
+ Misses        3336     3332       -4     
+ Partials       304      303       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@shrouti1507
Copy link
Contributor Author

#3325 This PR is raised instead

@devops-github-rudderstack devops-github-rudderstack deleted the fix.awin-custom branch July 25, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants