Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty userId (movable ink, bloomreach) #3300

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Apr 22, 2024

What are the changes introduced in this PR?

Checking empty userId with ?? is giving wrong result for empty userId userId= "" in payload. Updated the movable ink and bloomreach destination to use || operator to check for truthy values for userId.

What is the related Linear task?

Resolves INT-2047

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

@Gauravudia Gauravudia changed the title fix: handle empty userId fix: handle empty userId (movable ink, bloomreach) Apr 22, 2024
@Gauravudia Gauravudia added the DO NOT MERGE Don't merge this PR without having discussion label Apr 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (adb5751) to head (5402b21).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3300   +/-   ##
========================================
  Coverage    87.86%   87.86%           
========================================
  Files          556      556           
  Lines        29996    29996           
  Branches      7172     7172           
========================================
  Hits         26356    26356           
  Misses        3336     3336           
  Partials       304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia removed the DO NOT MERGE Don't merge this PR without having discussion label Apr 23, 2024
@Gauravudia Gauravudia self-assigned this Apr 23, 2024
@Gauravudia Gauravudia marked this pull request as ready for review April 23, 2024 06:00
@Gauravudia Gauravudia requested review from a team and sivashanmukh as code owners April 23, 2024 06:00
Copy link
Contributor

@anantjain45823 anantjain45823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have a check as well for userId to be string

@Gauravudia Gauravudia merged commit 038c1aa into develop Apr 26, 2024
18 checks passed
@Gauravudia Gauravudia deleted the fix.empty-userId branch April 26, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants