chore: onboard custom mappings for GA4 #3289
Conversation
utsabc
requested review from
shrouti1507,
Gauravudia,
krishna2020 and
koladilip
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3289/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3289 +/- ##
===========================================
- Coverage 88.02% 88.00% -0.03%
===========================================
Files 570 572 +2
Lines 30773 30910 +137
Branches 7351 7387 +36
===========================================
+ Hits 27089 27202 +113
- Misses 3349 3370 +21
- Partials 335 338 +3 ☔ View full report in Codecov by Sentry. |
…to feat.custom_mappings
|
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
updated test cases as some cases are not valid.
| const targetPathWithIndex = targetPath.replace(/\[\*]/g, `[${i}]`); | ||
| const tragetValue = values[i] ? values[i] : null; | ||
| jsonpath.value(targetObject, targetPathWithIndex, tragetValue); | ||
| const sanitizeUserProperties = (userProperties) => { |
There was a problem hiding this comment.
plan for unit test case later on
krishna2020
changed the title
There was a problem hiding this comment.
All business scenarios of GA4 should also be working here
|
What are the changes introduced in this PR?
Onboard custom mappings logic for transformer
What is the related Linear task?
Resolves INT-2183, Resolves INT-2240
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.