chore: support event validation for old and new tracking plan payload formats #3255
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3255/test-report.html |
Jayachand
requested review from
ssbeefeater
and removed request for
chandumlg and
shrouti1507
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3255 +/- ##
========================================
Coverage 87.85% 87.85%
========================================
Files 556 556
Lines 29993 29997 +4
Branches 7169 7172 +3
========================================
+ Hits 26351 26355 +4
- Misses 3310 3338 +28
+ Partials 332 304 -28 ☔ View full report in Codecov by Sentry. |
|
I would argue to separate the validation completely rather than adding validation pathways to an existing tracking plan. This migration will take time to complete fully and in meantime we would have divergence. I am thinking to separate them out completely. Wdyt ? |
|
Is it possible to write another test suite for new tracking plan rather than adding into the same test suite. Wdyt ? |
|
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
fixes DAT-1065
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.