Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding product level tracking for awin #3246

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Apr 3, 2024

What are the changes introduced in this PR?

Adding product level tracking for track events.
ref : https://wiki.awin.com/index.php/Advertiser_Tracking_Guide/Product_Level_Tracking#PLT_Via_Conversion_Pixel

What is the related Linear task?

Resolves INT-1757

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners April 3, 2024 14:12
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (218f08c) to head (e8d191f).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3246      +/-   ##
===========================================
+ Coverage    87.78%   87.79%   +0.01%     
===========================================
  Files          556      556              
  Lines        29832    29863      +31     
  Branches      7110     7120      +10     
===========================================
+ Hits         26188    26219      +31     
- Misses        3308     3336      +28     
+ Partials       336      308      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ItsSudip
ItsSudip previously approved these changes Apr 3, 2024
src/v0/destinations/awin/utils.js Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Apr 8, 2024

@shrouti1507 shrouti1507 merged commit 48cf9f2 into develop Apr 8, 2024
16 checks passed
@shrouti1507 shrouti1507 deleted the enhance.awin branch April 8, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants