Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: component test refactor for intercom destination #3236

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

mihir-4116
Copy link
Contributor

What are the changes introduced in this PR?

  • This pr contains component test refactor for intercom destination

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@mihir-4116 mihir-4116 self-assigned this Apr 2, 2024
@mihir-4116 mihir-4116 requested review from sivashanmukh and a team as code owners April 2, 2024 10:13
@mihir-4116 mihir-4116 changed the title chore: component test refactor for intercom destination chore(INT-1931): component test refactor for intercom destination Apr 2, 2024
@mihir-4116 mihir-4116 changed the title chore(INT-1931): component test refactor for intercom destination chore: component test refactor for intercom destination Apr 2, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (adb5751) to head (8ab930c).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3236      +/-   ##
===========================================
+ Coverage    87.86%   87.88%   +0.01%     
===========================================
  Files          556      556              
  Lines        29996    29994       -2     
  Branches      7172     7172              
===========================================
+ Hits         26356    26359       +3     
+ Misses        3336     3304      -32     
- Partials       304      331      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sanpj2292 sanpj2292 merged commit 89a71b7 into develop Apr 24, 2024
16 checks passed
@sanpj2292 sanpj2292 deleted the feat.intercom-component-test-refactor branch April 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants