Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix deployment conflicts #3230

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

yashasvibajpai
Copy link
Contributor

What are the changes introduced in this PR?

Fix deployment conflicts.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai requested a review from ItsSudip April 1, 2024 14:13
@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners April 1, 2024 14:14
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (4ea55d1) to head (ee89255).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3230      +/-   ##
===========================================
+ Coverage    87.71%   87.78%   +0.07%     
===========================================
  Files          550      556       +6     
  Lines        29616    29828     +212     
  Branches      7060     7108      +48     
===========================================
+ Hits         25977    26185     +208     
- Misses        3303     3335      +32     
+ Partials       336      308      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@krishna2020 krishna2020 merged commit 84cdf5f into develop Apr 1, 2024
16 checks passed
@krishna2020 krishna2020 deleted the chore.fix.deployment.conflicts branch April 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants