Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logger upgrade in services, dest, source #3228

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

aashishmalik
Copy link
Contributor

@aashishmalik aashishmalik commented Apr 1, 2024

What are the changes introduced in this PR?

logging introduction as more structured in trasnformer repository.
Added child loggers, which will log all the info available till that execution

in destination.ts it prints

{"extraData":{"destinationId":"destId","workspaceId":"workspaceId"},"level":"info","message":"Native(Process-Transform):: Requst to transformer::","timestamp":"2024-04-09 11:17:29"}

Further in service after more info is provided to child contet

{"extraData":{"destType":"TWITTER_ADS","destinationId":"destId","feature":"processor","implementation":"native","module":"destination","workspaceId":"workspaceId"},"level":"info","message":"nativeIntegration service","timestamp":"2024-04-09 11:17:29"}

What is the related Linear task?

Resolves INT-1569, INT-1111,

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aashishmalik aashishmalik marked this pull request as ready for review April 1, 2024 12:59
@aashishmalik aashishmalik requested review from a team and sivashanmukh as code owners April 1, 2024 12:59
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 92.36641% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 87.81%. Comparing base (679a318) to head (ed32176).
Report is 12 commits behind head on develop.

Files Patch % Lines
src/controllers/bulkUpload.ts 14.28% 6 Missing ⚠️
src/controllers/delivery.ts 83.33% 2 Missing ⚠️
src/services/destination/postTransformation.ts 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3228      +/-   ##
===========================================
+ Coverage    87.78%   87.81%   +0.03%     
===========================================
  Files          556      556              
  Lines        29831    29930      +99     
  Branches      7107     7148      +41     
===========================================
+ Hits         26187    26284      +97     
+ Misses        3336     3310      -26     
- Partials       308      336      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krishna2020
Copy link
Collaborator

@aashishmalik can you update the sample log from logs based on new changes in PR description ?

@aashishmalik
Copy link
Contributor Author

aashishmalik commented Apr 1, 2024

@aashishmalik can you update the sample log from logs based on new changes in PR description ?

@krishna2020 https://www.notion.so/rudderstacks/Logging-Transformer-Docs-d4dbc60f5e964a91ad4b84432349ca50

@aashishmalik aashishmalik requested a review from krishna2020 April 2, 2024 11:15
@aashishmalik aashishmalik requested a review from a team as a code owner April 9, 2024 01:50
Copy link

sonarqubecloud bot commented Apr 9, 2024

@aashishmalik aashishmalik requested a review from sanpj2292 April 9, 2024 06:47
@aashishmalik aashishmalik requested a review from sanpj2292 April 9, 2024 07:10
Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove public static logError(message: string, errorDetailer: ErrorDetailer) { in another PR

@aashishmalik aashishmalik merged commit c204113 into develop Apr 9, 2024
18 checks passed
@aashishmalik aashishmalik deleted the feat.logging-updates branch April 9, 2024 12:35
aashishmalik added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants