-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logger upgrade in services, dest, source #3228
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3228/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3228 +/- ##
===========================================
+ Coverage 87.78% 87.81% +0.03%
===========================================
Files 556 556
Lines 29831 29930 +99
Branches 7107 7148 +41
===========================================
+ Hits 26187 26284 +97
+ Misses 3336 3310 -26
- Partials 308 336 +28 ☔ View full report in Codecov by Sentry. |
@aashishmalik can you update the sample log from logs based on new changes in PR description ? |
@krishna2020 https://www.notion.so/rudderstacks/Logging-Transformer-Docs-d4dbc60f5e964a91ad4b84432349ca50 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove public static logError(message: string, errorDetailer: ErrorDetailer) { in another PR
This reverts commit c204113.
What are the changes introduced in this PR?
logging introduction as more structured in trasnformer repository.
Added child loggers, which will log all the info available till that execution
What is the related Linear task?
Resolves INT-1569, INT-1111,
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.