Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do away myaxios #3222

Merged
merged 7 commits into from
Apr 9, 2024
Merged

feat: do away myaxios #3222

merged 7 commits into from
Apr 9, 2024

Conversation

aashishmalik
Copy link
Contributor

What are the changes introduced in this PR?

do away myaxios in sfmc

What is the related Linear task?

Resolves INT-1911

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aashishmalik aashishmalik requested a review from a team as a code owner March 31, 2024 16:27
@aashishmalik aashishmalik marked this pull request as draft March 31, 2024 16:28
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (218f08c) to head (986507c).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3222      +/-   ##
===========================================
+ Coverage    87.78%   87.82%   +0.04%     
===========================================
  Files          556      556              
  Lines        29832    29889      +57     
  Branches      7110     7134      +24     
===========================================
+ Hits         26188    26251      +63     
- Misses        3308     3334      +26     
+ Partials       336      304      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashishmalik aashishmalik marked this pull request as ready for review April 4, 2024 18:15
@aashishmalik aashishmalik requested review from sivashanmukh and a team as code owners April 4, 2024 18:15
@aashishmalik aashishmalik requested a review from sanpj2292 April 8, 2024 06:19
@aashishmalik aashishmalik requested a review from sanpj2292 April 9, 2024 02:02
@aashishmalik aashishmalik requested a review from sanpj2292 April 9, 2024 07:11
Copy link

sonarqubecloud bot commented Apr 9, 2024

@aashishmalik aashishmalik requested a review from mihir-4116 April 9, 2024 07:39
@aashishmalik aashishmalik merged commit 9214594 into develop Apr 9, 2024
16 checks passed
@aashishmalik aashishmalik deleted the feat.sfmc-myaxios branch April 9, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants