Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ga4): component test refactor #3220

Merged
merged 5 commits into from
May 15, 2024
Merged

Conversation

mihir-4116
Copy link
Contributor

What are the changes introduced in this PR?

  • This pr contains component test refactor of ga4 destination

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@mihir-4116 mihir-4116 self-assigned this Mar 28, 2024
@mihir-4116 mihir-4116 requested review from sivashanmukh and a team as code owners March 28, 2024 07:54
@mihir-4116 mihir-4116 changed the title feat(ga4): component test refactor feat(INT-1471): component test refactor Mar 28, 2024
@mihir-4116 mihir-4116 changed the title feat(INT-1471): component test refactor feat(ga4): component test refactor Mar 28, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (5402b21) to head (a6f753c).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3220   +/-   ##
========================================
  Coverage    87.86%   87.86%           
========================================
  Files          556      558    +2     
  Lines        29996    30045   +49     
  Branches      7172     7191   +19     
========================================
+ Hits         26356    26400   +44     
- Misses        3336     3342    +6     
+ Partials       304      303    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ItsSudip ItsSudip merged commit 3ff9a5e into develop May 15, 2024
16 checks passed
@ItsSudip ItsSudip deleted the feat.ga4-component-test-refactor branch May 15, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants