fix: tiktok_ads: validate message.event type #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gauravudia
approved these changes
Mar 26, 2024
utsabc
reviewed
Mar 26, 2024
Comment on lines
135
to
136
| if (!event) { | ||
| throw new InstrumentationError('Event name is required'); |
There was a problem hiding this comment.
Shouldnt validateEventName take care of it?
There was a problem hiding this comment.
In case the event name is an empty string it would not take care of it
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3203/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix-release/v1.60.0 #3203 +/- ##
==========================================================
- Coverage 87.70% 87.69% -0.01%
==========================================================
Files 550 550
Lines 29585 29585
Branches 7054 7055 +1
==========================================================
- Hits 25947 25946 -1
+ Misses 3330 3303 -27
- Partials 308 336 +28 ☔ View full report in Codecov by Sentry. |
utsabc
approved these changes
Mar 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Validating Event Type for tiktok_ads.
Write a brief explainer on your code changes.
What is the related Linear task?
Resolves INT-1889
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.