Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup transformer code with openfaas pro deployment changes #3180

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

abhimanyubabbar
Copy link
Contributor

@abhimanyubabbar abhimanyubabbar commented Mar 12, 2024

What are the changes introduced in this PR?

We recently bought license for openfaas standard which brings in host of benefits like autoscaler and better dashboards. This allows us to save a lot of cost when deploying openfaas stack. This change allows your UT service to be pro compliant by:

  1. Introducing more labels on the UT pods needed by the pro setup
  2. Allowing to pass basic auth credentials in request being sent to gateway pods.

These changes are backward compatible.

What is the related Linear task?

Fixes DAT-1093

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link
Contributor

coderabbitai bot commented Mar 12, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@abhimanyubabbar abhimanyubabbar changed the title setup transformer code with openfaas pro deployment changes chore: setup transformer code with openfaas pro deployment changes Mar 12, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (218f08c) to head (a219122).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3180      +/-   ##
===========================================
+ Coverage    87.78%   87.85%   +0.06%     
===========================================
  Files          556      556              
  Lines        29832    29941     +109     
  Branches      7110     7155      +45     
===========================================
+ Hits         26188    26304     +116     
+ Misses        3308     3305       -3     
+ Partials       336      332       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sanpj2292 sanpj2292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a brief description on why we're making changes ?
We follow conventional-commits format for commit messages. Can you as well check and amend the commit made accordingly ?

@abhimanyubabbar abhimanyubabbar force-pushed the chore/openfaas-pro-setup branch from 5f29467 to afb08b6 Compare April 3, 2024 16:32
@abhimanyubabbar abhimanyubabbar force-pushed the chore/openfaas-pro-setup branch 2 times, most recently from a486ad3 to 6fc3c01 Compare April 12, 2024 13:35
@abhimanyubabbar abhimanyubabbar force-pushed the chore/openfaas-pro-setup branch from 6fc3c01 to a219122 Compare April 12, 2024 13:37
Copy link

Copy link
Collaborator

@Jayachand Jayachand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhimanyubabbar abhimanyubabbar merged commit 3721a44 into develop Apr 12, 2024
18 checks passed
@abhimanyubabbar abhimanyubabbar deleted the chore/openfaas-pro-setup branch April 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants