Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/v1.58.0 into main #3162

Merged
merged 35 commits into from
Mar 5, 2024
Merged

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

yashasvibajpai and others added 30 commits February 22, 2024 22:49
* chore: add requestMethod and module label x1

* chore: add requestMethod and module label x2

* chore: add requestMethod and module latency labels (#3097)

* chore: added statuscode stat for user deletion (#3108)

* fix: component tests

---------

Co-authored-by: Mihir Bhalala <[email protected]>
Co-authored-by: mihir-4116 <[email protected]>
* fix: remove ztringification for nested objects and arrays in profileData

* fix: remove ztringification for nested objects and arrays in event data for custom events

* chore: update test on category-unsubscribe

* fix: revert "remove ztringification for nested objects and arrays in event data for custom events" commit

This reverts commit 9157b28.

* fix: allow stringification for subscription properties only

---------

Co-authored-by: Sudip Paul <[email protected]>
* fix: reddit revenue mapping for floating point values

* fix: reddit revenue mapping for floating point values
…d spec (#3129)

* fix: rakuten: sync property mapping sourcekeys to rudderstack standard spec

* chore: comments addressed
…3139)

chore: remove config generator info from contribution guide
* feat: add support for interaction events in sfmc

* chore: refactorx1

* chore: fix response structure

* chore: add test

* chore: map contect key from properties instead of userId

* chore: add component test
* feat: update klaviyo profile mapping

* test: update testcases
* feat: onboard new destination ninetailed

* chore: added test cases for processor

* chore: small fix

* chore: added test cases for router

* chore: small fix

* chore: address comments

* chore: added router test case for max batch size

* fix: test cases

* fix: eslint issues
* feat: update proxy data type for response handler input

* feat: update proxy v1 test cases

* feat: update proxy tests for cm360
Added new structure for proxy test scnearios for cm360 also added zod validations as part of tests

* fix: typo

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: api contract for v1 proxy

* chore: clean up zod type

* chore: update testutils

* chore: update V0 proxy request type and zod schema

* feat: adding zod validations (#3066)

* feat: add type definitions for test cases

* fix: update networkHandler for rakuten

---------

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: update delivery test cases for criteo audience

* Revert "chore: update delivery test cases for criteo audience"

This reverts commit 689b0cd.

* chore: add type def for proxy v1 test

* chore: fix generateMetdata func

* chore: criteo audience update proxy test (#3068)

* chore: update delivery test cases for criteo audience

* chore: enable batch response schema check (#3083)

* chore: reddit proxy test refactor

* chore: code review changes

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: ItsSudip <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: chandumlg <[email protected]>
… conversions (#3113)

* feat(facebook): update content_type mapping logic for fb pixel and fb conversions

* feat(facebook): update content_type mapping logic for fb conversions

* chore: added tests

* chore: updated tests
* feat: add support of custom page/screen event name in mixpanel

* refactor: use handlebars

* test: add testcase for multiple handlebars

* refactor: replace handlebar with regex

* refactor: update error message

* refactor: generatePageOrScreenCustomEventName

* fix: skip event trimming
* chore: fb app events v1 tests

* chore: fb app events v1 tests

* chore: removed unused constants

* chore: updated tests
* feat: update proxy data type for response handler input

* feat: update proxy v1 test cases

* feat: update proxy tests for cm360
Added new structure for proxy test scnearios for cm360 also added zod validations as part of tests

* fix: typo

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: api contract for v1 proxy

* chore: clean up zod type

* chore: update testutils

* chore: update V0 proxy request type and zod schema

* feat: adding zod validations (#3066)

* feat: add type definitions for test cases

* fix: update networkHandler for rakuten

---------

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: update delivery test cases for criteo audience

* Revert "chore: update delivery test cases for criteo audience"

This reverts commit 689b0cd.

* chore: add type def for proxy v1 test

* chore: fix generateMetdata func

* chore: criteo audience update proxy test (#3068)

* chore: update delivery test cases for criteo audience

* chore: enable batch response schema check (#3083)

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: braze proxy v1 test (#3087)

* chore: refactor braze proxy v1 tests

* chore: address review comments and cleanup

* chore: cleanup of mock

---------

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: updated tests

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: ItsSudip <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: chandumlg <[email protected]>
* fix: add error handling for tiktok ads

* chore: address comment
* chore: facebook_pixel to v1 proxy tests

* chore: updated tests

* chore: updated tests

* chore: updated tests

* chore: updated tests
Copy link
Contributor

coderabbitai bot commented Mar 4, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@devops-github-rudderstack
Copy link
Contributor Author

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 91.75258% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 84.86%. Comparing base (7463891) to head (dff7eb9).

Files Patch % Lines
src/v0/destinations/mp/util.js 71.42% 4 Missing ⚠️
src/cdk/v2/destinations/ninetailed/utils.js 95.23% 2 Missing ⚠️
src/util/customTransformer.js 0.00% 2 Missing ⚠️
src/util/stats.js 33.33% 2 Missing ⚠️
src/v0/util/index.js 75.00% 2 Missing ⚠️
src/util/customTransformer-v1.js 66.66% 1 Missing ⚠️
src/util/customTransformerFactory.js 75.00% 1 Missing ⚠️
src/util/ivmFactory.js 66.66% 1 Missing ⚠️
src/v0/destinations/mp/transform.js 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3162   +/-   ##
=======================================
  Coverage   84.86%   84.86%           
=======================================
  Files         497      497           
  Lines       27412    27412           
  Branches     6597     6599    +2     
=======================================
  Hits        23262    23262           
+ Misses       3723     3694   -29     
- Partials      427      456   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@koladilip koladilip merged commit d40c923 into main Mar 5, 2024
20 checks passed
@koladilip koladilip deleted the release/v1.58.0 branch March 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.