feat: add record event support for redis destination #3124
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3124/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3124 +/- ##
===========================================
+ Coverage 84.51% 84.90% +0.39%
===========================================
Files 493 496 +3
Lines 27301 27384 +83
Branches 6569 6591 +22
===========================================
+ Hits 23073 23250 +177
+ Misses 3771 3681 -90
+ Partials 457 453 -4 ☔ View full report in Codecov by Sentry. |
| // }, | ||
| // } | ||
|
|
||
| function handleRecordEventsForRedis(message, destination, metadata) { |
There was a problem hiding this comment.
There is no need to add "Redis" in the name. It's part of the Redis directory, so it's understood.
There was a problem hiding this comment.
Maybe you haven't pushed the changes to upstream.
| @@ -35,7 +36,10 @@ const transformSubEventTypeProfiles = (message, workspaceId, destinationId) => { | |||
| // form the hash | |||
| const hash = `${workspaceId}:${destinationId}:${message.context.sources.profiles_entity}:${message.context.sources.profiles_id_type}:${message.userId}`; | |||
| const key = `${message.context.sources.profiles_model}`; | |||
| const value = JSON.stringify(message.traits); | |||
| let value = JSON.stringify(message.traits); | |||
There was a problem hiding this comment.
We should not JSON stringify traits by default if it is possible to not use them.
There was a problem hiding this comment.
It was being stringified before also, should I remove the stringification?
There was a problem hiding this comment.
The implementation should have looked something like this,
if event type is record {
// do record specific logic
} else {
// stringify traits
}
There was a problem hiding this comment.
Right now the flow is
event -
-
if event is a record type event
-
- handle insert/delete action related logic
-
if event is having profiles' contextual data
-
- it is a profiles-identify event (backward compatible, only insertion supported)
-
for none of the above
-- it is a standard redis destination's identify event
There was a problem hiding this comment.
I don't think you're getting it.
I meant that you should not stringify traits by default. Instead, do it only for non-record type of event flows.
| @@ -0,0 +1,45 @@ | |||
| const { transformSubEventTypeProfiles } = require('./transform'); | |||
There was a problem hiding this comment.
Do we really need a "v2" file? It doesn't seem like a convention.
There was a problem hiding this comment.
Fixed it to a utils.js file name
yashasvibajpai
requested review from
shrouti1507,
anantjain45823 and
saikumarrs
|
Lets discuss over all with @saikumarrs |
|
|
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
devops-github-rudderstack
deleted the
feat.support.record.events.for.redis
branch
What are the changes introduced in this PR?
Add record event support for redis destination
What is the related Linear task?
Resolves INT-978
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.