chore: braze proxy v1 test #3087

utsabc · 2024-02-13T07:16:34Z

What are the changes introduced in this PR?

Refactor proxy v1 tests for Braze Integration

What is the related Linear task?

Resolves INT-1478

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

Developer checklist

My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?

Reviewer checklist

Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.

coderabbitai · 2024-02-13T07:16:47Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

devops-github-rudderstack · 2024-02-13T07:21:05Z

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3087/test-report.html

codecov · 2024-02-13T07:26:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33d4d62) 87.27% compared to head (0f8e8cd) 87.28%.
Report is 2 commits behind head on fix.network-handlers.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           fix.network-handlers    #3087   +/-   ##
=====================================================
  Coverage                 87.27%   87.28%           
=====================================================
  Files                       538      538           
  Lines                     29322    29322           
  Branches                   6978     6978           
=====================================================
+ Hits                      25592    25593    +1     
+ Misses                     3387     3386    -1     
  Partials                    343      343

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

koladilip · 2024-02-13T07:29:43Z

test/integrations/destinations/braze/dataDelivery/business.ts

+              },
+              {
+                error:
+                  '{"events_processed":1,"message":"success","errors":[{"type":"\'external_id\', \'braze_id\', \'user_alias\', \'email\' or \'phone\' is required","input_array":"events","index":1},{"type":"\'quantity\' is not valid","input_array":"purchases","index":0}]}',


koladilip · 2024-02-13T07:30:01Z

test/integrations/destinations/braze/dataDelivery/business.ts

+            response: [
+              {
+                error:
+                  '{"message":"Valid data must be provided in the \'attributes\', \'events\', or \'purchases\' fields.","errors":[{"type":"\'external_id\', \'braze_id\', \'user_alias\', \'email\' or \'phone\' is required","input_array":"events","index":0},{"type":"\'external_id\', \'braze_id\', \'user_alias\', \'email\' or \'phone\' is required","input_array":"events","index":1},{"type":"\'quantity\' is not valid","input_array":"purchases","index":0}]}',


koladilip · 2024-02-13T07:31:03Z

test/integrations/destinations/braze/dataDelivery/other.ts

+                },
+              },
+            ],
+            statTags: {


can we create a reusable function for this

declared a common variable

koladilip · 2024-02-13T07:31:17Z

test/integrations/destinations/braze/dataDelivery/other.ts

+                  '{"error":{"message":"Service Unavailable","description":"The server is currently unable to handle the request due to temporary overloading or maintenance of the server. Please try again later."}}',
+                statusCode: 503,
+                metadata: {
+                  jobId: 1,


can we use getMetadata(1) here?

koladilip · 2024-02-13T07:31:45Z

test/integrations/destinations/braze/dataDelivery/other.ts

+                error: '"Internal Server Error"',
+                statusCode: 500,
+                metadata: {
+                  jobId: 1,


getMetadata(1)

koladilip · 2024-02-13T07:32:43Z

test/integrations/destinations/braze/network.ts

+        name: 'Broman Hoodie',
+        price: '97.99',
+        variant: [
+          {


looks repeated

these were not used hence cleaned up

devops-github-rudderstack · 2024-02-14T11:54:08Z

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3087/test-report.html

devops-github-rudderstack · 2024-02-14T11:56:54Z

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3087/test-report.html

sonarqubecloud · 2024-02-14T11:59:58Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* feat: update proxy data type for response handler input * feat: update proxy v1 test cases * feat: update proxy tests for cm360 Added new structure for proxy test scnearios for cm360 also added zod validations as part of tests * fix: typo * Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: api contract for v1 proxy * chore: clean up zod type * chore: update testutils * chore: update V0 proxy request type and zod schema * feat: adding zod validations (#3066) * feat: add type definitions for test cases * fix: update networkHandler for rakuten --------- Co-authored-by: Utsab Chowdhury <[email protected]> * chore: update delivery test cases for criteo audience * Revert "chore: update delivery test cases for criteo audience" This reverts commit 689b0cd. * chore: add type def for proxy v1 test * chore: fix generateMetdata func * chore: criteo audience update proxy test (#3068) * chore: update delivery test cases for criteo audience * chore: enable batch response schema check (#3083) * chore: fb_custom_audience v1 tests * chore: fb_custom_audience v1 tests * chore: fb_custom_audience v1 tests * chore: braze proxy v1 test (#3087) * chore: refactor braze proxy v1 tests * chore: address review comments and cleanup * chore: cleanup of mock --------- Co-authored-by: Utsab Chowdhury <[email protected]> * chore: fb_custom_audience v1 tests * chore: fb_custom_audience v1 tests * chore: fb_custom_audience v1 tests * chore: fb_custom_audience v1 tests * chore: updated tests --------- Co-authored-by: Utsab Chowdhury <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Utsab Chowdhury <[email protected]> Co-authored-by: ItsSudip <[email protected]> Co-authored-by: Sudip Paul <[email protected]> Co-authored-by: chandumlg <[email protected]>

chore: refactor braze proxy v1 tests

7083001

utsabc requested review from a team and sivashanmukh as code owners February 13, 2024 07:16

utsabc requested review from anantjain45823 and mihir-4116 February 13, 2024 07:16

utsabc changed the base branch from develop to fix.network-handlers February 13, 2024 07:16

koladilip reviewed Feb 13, 2024

View reviewed changes

Utsab Chowdhury added 2 commits February 14, 2024 17:21

chore: address review comments and cleanup

3938118

chore: cleanup of mock

0f8e8cd

utsabc requested a review from koladilip February 14, 2024 11:54

koladilip approved these changes Feb 14, 2024

View reviewed changes

utsabc merged commit a8b8f23 into fix.network-handlers Feb 15, 2024
14 checks passed

utsabc deleted the chore.braze-proxy-v1-test branch February 15, 2024 06:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: braze proxy v1 test #3087

chore: braze proxy v1 test #3087

utsabc commented Feb 13, 2024 •

edited

Loading

coderabbitai bot commented Feb 13, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

devops-github-rudderstack commented Feb 13, 2024

codecov bot commented Feb 13, 2024 •

edited

Loading

koladilip Feb 13, 2024

utsabc Feb 14, 2024

koladilip Feb 13, 2024

utsabc Feb 14, 2024

koladilip Feb 13, 2024

utsabc Feb 14, 2024

koladilip Feb 13, 2024

utsabc Feb 14, 2024

koladilip Feb 13, 2024

utsabc Feb 14, 2024

koladilip Feb 13, 2024

utsabc Feb 14, 2024

devops-github-rudderstack commented Feb 14, 2024

devops-github-rudderstack commented Feb 14, 2024

sonarqubecloud bot commented Feb 14, 2024

chore: braze proxy v1 test #3087

chore: braze proxy v1 test #3087

Conversation

utsabc commented Feb 13, 2024 • edited Loading

What are the changes introduced in this PR?

What is the related Linear task?

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

Any new dependencies introduced with this change?

Any new generic utility introduced or modified. Please explain the changes.

Any technical or performance related pointers to consider with the change?

Developer checklist

Reviewer checklist

coderabbitai bot commented Feb 13, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

devops-github-rudderstack commented Feb 13, 2024

codecov bot commented Feb 13, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devops-github-rudderstack commented Feb 14, 2024

devops-github-rudderstack commented Feb 14, 2024

sonarqubecloud bot commented Feb 14, 2024

Quality Gate passed

utsabc commented Feb 13, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Feb 13, 2024 •

edited

Loading