Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable batch response schema check #3083

Merged

Conversation

chandumlg
Copy link
Member

What are the changes introduced in this PR?

enable batch response schema check

What is the related Linear task?

https://linear.app/rudderstack/issue/INT-1298/enhance-component-test-suite-to-do-server-contract-validations-for

Please explain the objectives of your changes below

Adding contract validations for batch endpoint.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@chandumlg chandumlg requested review from sivashanmukh and a team as code owners February 12, 2024 19:59
Copy link
Contributor

coderabbitai bot commented Feb 12, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@devops-github-rudderstack
Copy link
Contributor

Copy link

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33d4d62) 87.27% compared to head (ab4db28) 87.27%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           fix.network-handlers    #3083   +/-   ##
=====================================================
  Coverage                 87.27%   87.27%           
=====================================================
  Files                       538      538           
  Lines                     29322    29322           
  Branches                   6978     6978           
=====================================================
  Hits                      25592    25592           
  Misses                     3387     3387           
  Partials                    343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chandumlg chandumlg requested a review from utsabc February 12, 2024 20:07
@chandumlg chandumlg merged commit c7133b3 into fix.network-handlers Feb 13, 2024
14 checks passed
@chandumlg chandumlg deleted the chore.enable-batch-response-schema-check branch February 13, 2024 13:58
mihir-4116 added a commit that referenced this pull request Mar 1, 2024
* feat: update proxy data type for response handler input

* feat: update proxy v1 test cases

* feat: update proxy tests for cm360
Added new structure for proxy test scnearios for cm360 also added zod validations as part of tests

* fix: typo

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: api contract for v1 proxy

* chore: clean up zod type

* chore: update testutils

* chore: update V0 proxy request type and zod schema

* feat: adding zod validations (#3066)

* feat: add type definitions for test cases

* fix: update networkHandler for rakuten

---------

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: update delivery test cases for criteo audience

* Revert "chore: update delivery test cases for criteo audience"

This reverts commit 689b0cd.

* chore: add type def for proxy v1 test

* chore: fix generateMetdata func

* chore: criteo audience update proxy test (#3068)

* chore: update delivery test cases for criteo audience

* chore: enable batch response schema check (#3083)

* chore: reddit proxy test refactor

* chore: code review changes

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: ItsSudip <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: chandumlg <[email protected]>
sandeepdsvs added a commit that referenced this pull request Mar 1, 2024
* feat: update proxy data type for response handler input

* feat: update proxy v1 test cases

* feat: update proxy tests for cm360
Added new structure for proxy test scnearios for cm360 also added zod validations as part of tests

* fix: typo

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update test/integrations/destinations/campaign_manager/dataDelivery/business.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: api contract for v1 proxy

* chore: clean up zod type

* chore: update testutils

* chore: update V0 proxy request type and zod schema

* feat: adding zod validations (#3066)

* feat: add type definitions for test cases

* fix: update networkHandler for rakuten

---------

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: update delivery test cases for criteo audience

* Revert "chore: update delivery test cases for criteo audience"

This reverts commit 689b0cd.

* chore: add type def for proxy v1 test

* chore: fix generateMetdata func

* chore: criteo audience update proxy test (#3068)

* chore: update delivery test cases for criteo audience

* chore: enable batch response schema check (#3083)

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: braze proxy v1 test (#3087)

* chore: refactor braze proxy v1 tests

* chore: address review comments and cleanup

* chore: cleanup of mock

---------

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: fb_custom_audience v1 tests

* chore: updated tests

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: ItsSudip <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: chandumlg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants