Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gaoc batching order #3064

Merged
merged 4 commits into from
Feb 13, 2024
Merged

fix: gaoc batching order #3064

merged 4 commits into from
Feb 13, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Feb 6, 2024

What are the changes introduced in this PR?

  • Fix the duplicate jobId's returned in output for google adwords offline conversions (GAOC is returning 2 batch requests for same jobId)
  • moved utility combineBatchRequestsWithSameJobIds from mixpanel to generic
    • moved sub-utilities findExistingBatch and removeDuplicateMetadata from mixpanel to generic
    • refactor findExistingBatch

What is the related Linear task?

Resolves INT-436

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

Moved combineBatchRequestsWithSameJobIds utility from mixpanel to generic. This utility will combine the batch requests with same jobId's for multiplexed input.

Any technical or performance related pointers to consider with the change?

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Gauravudia Gauravudia requested a review from ItsSudip February 6, 2024 11:59
@Gauravudia Gauravudia self-assigned this Feb 6, 2024
Copy link
Contributor

coderabbitai bot commented Feb 6, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (69c8348) 87.21% compared to head (4dc6639) 87.20%.

Files Patch % Lines
src/v0/util/index.js 96.96% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3064      +/-   ##
===========================================
- Coverage    87.21%   87.20%   -0.01%     
===========================================
  Files          537      537              
  Lines        29243    29238       -5     
  Branches      6963     6960       -3     
===========================================
- Hits         25503    25498       -5     
  Misses        3393     3393              
  Partials       347      347              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia marked this pull request as ready for review February 12, 2024 03:47
@Gauravudia Gauravudia requested review from a team and sivashanmukh as code owners February 12, 2024 03:47
@Gauravudia Gauravudia requested a review from sanpj2292 February 12, 2024 03:47
@devops-github-rudderstack
Copy link
Contributor

src/v0/util/index.js Outdated Show resolved Hide resolved
src/v0/util/index.js Outdated Show resolved Hide resolved
@devops-github-rudderstack
Copy link
Contributor

1 similar comment
@devops-github-rudderstack
Copy link
Contributor

Copy link

@Gauravudia Gauravudia requested a review from koladilip February 13, 2024 05:51
@Gauravudia Gauravudia merged commit a98cabd into develop Feb 13, 2024
16 checks passed
@Gauravudia Gauravudia deleted the fix/gaoc-batching-order branch February 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants