Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/v1.55.0 into main #3057

Merged
merged 20 commits into from
Feb 6, 2024
Merged

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

snyk-bot and others added 16 commits January 8, 2024 14:06
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.1.0 to 5.0.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4.1.0...v5.0.0)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…3037)

* fix: adding map for marketo known values and javascript known values

* fix: reverting launch.json to original state

* fix: editing test cases

* fix: review comments addressed

* fix: making error statement better

* feat: reviw comments addressed
)

* feat: initial commit

* fix: initial commit

* fix: adding unauthorized error for access token failure

* fix: reviw comments addressed

* feat: reviw comments addressed

* fix: changing version of integrations lib

* Apply suggestions from code review

Co-authored-by: Sankeerth <[email protected]>

* fix: review comments addressed

* fix: removing unnecessary tag

* fix: removing unnecessary log

* fix: review comments addressed

* fix: adding destination response

* Update src/v0/util/facebookUtils/networkHandler.js

Co-authored-by: Sankeerth <[email protected]>

---------

Co-authored-by: Sankeerth <[email protected]>
* feat(intercom): upgrade intercom version from 1.4 to 2.10

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: added backward compatibility for updateLastRequestAt field

* chore: intercom backward compatibility support

* chore: pr conflicts resolved

* chore: pr conflicts resolved

* chore: added step to check value of apiVersion

* chore: change default value of apiVersion to latest

* fix: intercom router response

* chore: code review changes

* chore: code review changes
* feat: initial commit

* refactor: added comments

* featL add payload builder utilities

* feat: add privacy settings and canonical names

* refactor: created separate transform.js for record and conversion use case

* feat: added getRevenue utility and unit testcases

* refactor: handle record/track type and added testcases

* fix: use map instead of forEach for async operations

* docs: add comments

* feat: review changes

* refactor: moved transform.js code logic to rtWorkflow

* feat: added generate exclusion list utility

* refactor: error message and function variable name

* refactor: import endpoint from config and added api links

* docs: add comments in response handler

* refactor: created separate validateConfig utility for both flows

* feat: updated category id mapping

* test: add generateExclusionList testcases
* feat: onboard new destination rakuten_advertising

* chore: small fix

* chore: onboard rakuten proxy

* chore: onboard rakuten proxy on v1

* chore: address comments and minor fixes

* chore: small fix

* chore: small fix for sonar issues

* chore: small fix for sonar issues+1

* chore: small fix for sonar issues+3

* chore: making name as a required field for every product

* Update src/cdk/v2/destinations/rakuten/utils.js

Co-authored-by: Dilip Kola <[email protected]>

* chore: address comments

---------

Co-authored-by: Dilip Kola <[email protected]>
Copy link
Contributor

coderabbitai bot commented Feb 5, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@devops-github-rudderstack
Copy link
Contributor Author

@devops-github-rudderstack
Copy link
Contributor Author

fix: trade desk extract custom properties util
@devops-github-rudderstack
Copy link
Contributor Author

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (be56ed7) 87.20% compared to head (7f04a59) 87.19%.

Files Patch % Lines
...destinations/the_trade_desk/transformConversion.js 93.47% 3 Missing ⚠️
src/v0/destinations/rakuten/networkHandler.js 97.22% 1 Missing ⚠️
...c/v0/destinations/the_trade_desk/networkHandler.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   87.20%   87.19%   -0.01%     
==========================================
  Files         530      537       +7     
  Lines       29079    29226     +147     
  Branches     6982     6963      -19     
==========================================
+ Hits        25357    25484     +127     
- Misses       3376     3394      +18     
- Partials      346      348       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor Author

@devops-github-rudderstack
Copy link
Contributor Author

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

18.3% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

@mihir-4116 mihir-4116 self-requested a review February 6, 2024 11:40
@aashishmalik aashishmalik merged commit 65338d6 into main Feb 6, 2024
16 of 18 checks passed
@aashishmalik aashishmalik deleted the release/v1.55.0 branch February 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.