Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clevertap remove stringification of array object properties #3048

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Feb 1, 2024

What are the changes introduced in this PR?

Remove paylaod properties stringification for subscription group properties in case of

  • profileData in user profiles (identify)

What is the related Linear task?

Resolves INT-1513

Please explain the objectives of your changes below

We need to add support for sending nested objects as it is to Clevertap. On investigation, it is found that this is only supported for upload profiles API (identify calls from Rudderstack). For events API (track calls from Rudderstack), it still returns an invalid response error like below

"response": "{"status":"fail","processed":0,"unprocessed":[{"status":"fail","code":512,"error":"Event data is incorrect. 512 - Only Items can have a nested structure, incorrect nested structure for field : prop1.Skipped record number : 1",

So for events, we will continue supporting stringifying the nested objects before sending to Clevertap.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link
Contributor

coderabbitai bot commented Feb 1, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@yashasvibajpai yashasvibajpai changed the title Fix.clevertap.stringification.issue fix: clevertap remove stringification of array object properties Feb 1, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69c8348) 87.21% compared to head (208ad83) 87.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3048   +/-   ##
========================================
  Coverage    87.21%   87.21%           
========================================
  Files          537      537           
  Lines        29243    29247    +4     
  Branches      6963     6966    +3     
========================================
+ Hits         25503    25507    +4     
  Misses        3393     3393           
  Partials       347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

…event data for custom events" commit

This reverts commit 9157b28.
@devops-github-rudderstack
Copy link
Contributor

@yashasvibajpai yashasvibajpai self-assigned this Feb 5, 2024
shrouti1507
shrouti1507 previously approved these changes Feb 6, 2024
ItsSudip
ItsSudip previously approved these changes Feb 6, 2024
@yashasvibajpai yashasvibajpai dismissed stale reviews from ItsSudip and shrouti1507 via f9b4013 February 7, 2024 19:24
@devops-github-rudderstack
Copy link
Contributor

@devops-github-rudderstack
Copy link
Contributor

Copy link

@yashasvibajpai yashasvibajpai merged commit 69e43b6 into develop Feb 23, 2024
14 checks passed
@yashasvibajpai yashasvibajpai deleted the fix.clevertap.stringification.issue branch February 23, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants