fix: for debugging via dedicated transformer #3020
Conversation
shrouti1507
added
DO NOT MERGE
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 872 872
Lines 29500 29502 +2
Branches 6865 6865
=======================================
+ Hits 25749 25751 +2
Misses 3405 3405
Partials 346 346 ☔ View full report in Codecov by Sentry. |
|
| @@ -143,6 +143,7 @@ const getFileData = async (inputEvents, config, headerArr) => { | |||
| requestTime = endTime - startTime; | |||
| stats.histogram('marketo_bulk_upload_create_file_time', requestTime); | |||
| stats.histogram('marketo_bulk_upload_upload_file_size', fileSize); | |||
| console.log(fileSize); | |||
There was a problem hiding this comment.
this should done using logger with proper message including what is the destination id etc
| @@ -336,6 +343,7 @@ const handleFileUploadResponse = (resp, successfulJobs, unsuccessfulJobs, reques | |||
| resp.response?.result[0]?.importId | |||
| ) { | |||
| const { importId } = resp.response.result[0]; | |||
| console.log(importId); | |||
There was a problem hiding this comment.
this should done using logger with proper message including what is the destination id etc
|
Used only for debugging via logs |
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
Resolves INT-1404
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.