Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixpanel timestamp in ms #2990

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: mixpanel timestamp in ms #2990

merged 1 commit into from
Jan 16, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Jan 15, 2024

What are the changes introduced in this PR?

Issue
Event ordering issue in mixpanel due to wrongly calculated timestamp for an event.
We are omitting millisecond precision when converting the timestamp to Unix timestamp using this utility. The utility rounds down the input timestamp to the nearest second.

Solution
Mixpanel accepts time in either seconds or milliseconds.
To address the event ordering issue in Mixpanel, Added a new utility :- toUnixTimestampInMS. Which will return the timestamp in milliseconds.

What is the related Linear task?

resolves INT-1339

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

Going forward passing timestamp in ms precision.
There was a bug in timestamp calculation for an event sent to mixpanel. Timestamp was calculated at second precision which can be same for 2 different event, causing event ordering issue in mixpanel.

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

toUnixTimestampInMS -> Returns timestamp in ms.

Any technical or performance related pointers to consider with the change?

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link
Contributor

coderabbitai bot commented Jan 15, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a959d4) 87.28% compared to head (f6a0890) 87.28%.

Additional details and impacted files
@@              Coverage Diff               @@
##           hotfix/jan.15    #2990   +/-   ##
==============================================
  Coverage          87.28%   87.28%           
==============================================
  Files                872      872           
  Lines              29500    29503    +3     
  Branches            6865     6868    +3     
==============================================
+ Hits               25749    25752    +3     
  Misses              3405     3405           
  Partials             346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia merged commit 0da63a4 into hotfix/jan.15 Jan 16, 2024
27 checks passed
@Gauravudia Gauravudia deleted the fix/mp-timestamp branch January 16, 2024 06:29
@Gauravudia Gauravudia restored the fix/mp-timestamp branch January 24, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants