feat(intercom): upgrade intercom version from 1.4 to 2.10 #2976
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2976 +/- ##
===========================================
+ Coverage 87.14% 87.15% +0.01%
===========================================
Files 530 529 -1
Lines 28812 28796 -16
Branches 6861 6865 +4
===========================================
- Hits 25109 25098 -11
+ Misses 3360 3355 -5
Partials 343 343 ☔ View full report in Codecov by Sentry. |
|
Not full review |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
1 similar comment
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2976/test-report.html |
|
What are the changes introduced in this PR?
What is the related Linear task?
Resolves INT-177
Please explain the objectives of your changes below
Identify call
1. An intermediate call is made to search for the contact.
2. If the contact is located, an update user call is made; otherwise, a create user call is initiated.
Track call
The track call process remains unchanged across both versions. It continues to add events to the respective user.
Group call
In v1.4, the response included two transformed outputs:
1. Creation or update of the company.
2. Addition of the user to the company.
With v2.10, the flow has been adjusted:
1. Initially, a contact lookup based on email is performed.
2. If a contact is found, an additional intermediate call is made to create and update the company. The final
payload, adding the user to the company, is then returned to the server.
4. If no contact is found, the second intermediate API call is skipped, and the response for creating or updating
the company is directly returned to the server.
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
Developer checklist
[✅ ] My code follows the style guidelines of this project
[❌ ] No breaking changes are being introduced.
[ ✅] All related docs linked with the PR?
[ ✅] All changes manually tested?
[✅ ] Any documentation changes needed with this change?
[ ❌] Is the PR limited to 10 file changes?
[ ✅] Is the PR limited to one linear task?
[✅ ] Are relevant unit and component test-cases added?
Reviewer checklist
[✅ ] Is the type of change in the PR title appropriate as per the changes?
[✅ ] Verified that there are no credentials or confidential data exposed with the changes.