Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send empty string instead of null when the schema data is undefined #2955

Merged

Conversation

sandeepdsvs
Copy link
Contributor

What are the changes introduced in this PR?

This PR fixes the following issue discussed in this thread for Zen Business customer.

Please explain the objectives of your changes below

This PR will make sure empty string, '' is sent instead of null when the schema data is undefined

Type of change

If the pull request is a bug-fix, enhancement or a refactor, please fill in the details on the changes made.

  • Existing capabilities/behavior
    If any schema field's value is undefined, null was sent as part of payload.data for that field.

  • New capabilities/behavior
    If any schema field's value is undefined, empty string will be sent as part of payload.data for that field.


Developer checklist

  • No breaking changes are being introduced.

  • Are all related docs linked with the PR?

  • Are all changes manually tested?

  • Does this change require any documentation changes?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sandeepdsvs sandeepdsvs requested review from a team and sivashanmukh as code owners December 26, 2023 12:47
@sandeepdsvs sandeepdsvs requested review from krishna2020 and shrouti1507 and removed request for a team December 26, 2023 12:47
Copy link
Contributor

coderabbitai bot commented Dec 26, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file
    • @coderabbitai modularize this function
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai gather interesting statistics about this repository and render them in a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (290854c) 87.27% compared to head (3e91ead) 87.27%.

Additional details and impacted files
@@                          Coverage Diff                          @@
##           hotfix/fb_custom_audience_schema_fix    #2955   +/-   ##
=====================================================================
  Coverage                                 87.27%   87.27%           
=====================================================================
  Files                                       790      790           
  Lines                                     29218    29218           
  Branches                                   6834     6835    +1     
=====================================================================
  Hits                                      25501    25501           
  Misses                                     3373     3373           
  Partials                                    344      344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sandeepdsvs sandeepdsvs merged commit 511741e into hotfix/fb_custom_audience_schema_fix Dec 26, 2023
15 checks passed
@sandeepdsvs sandeepdsvs deleted the fix.fbc_schema_error branch December 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants