fix: enhancement and version upgrade of google adwords enhanced conversion #2947

shrouti1507 · 2023-12-21T12:26:16Z

What are the changes introduced in this PR?

resolves INT-976

This PR is divided into destination level changes

Google has got a new API version 15. We are updating API version of

Google adwords enhanced conversion

Also we are adding support of the new fields added by google for this above destination

Doc references :

enhanced conversion --> adding job_id https://developers.google.com/google-ads/api/rest/reference/rest/v15/customers/uploadConversionAdjustments#ConversionAdjustment

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Type of change

enhancement

Existing capabilities/behavior
Same
New capabilities/behavior
added job Id value for conversions object.

If the pull request is a new feature,

Any technical or performance related pointers to consider with the change?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.

N/A

If multiple linear tasks are associated with the PR changes, please elaborate on the reason:

N/A

Developer checklist

No breaking changes are being introduced.
Are all related docs linked with the PR?
Are all changes manually tested?
Does this change require any documentation changes?
Are relevant unit and component test-cases added?

Reviewer checklist

Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.

coderabbitai · 2023-12-21T12:26:23Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

You can directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
- @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov · 2023-12-21T12:32:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bf56cc) 87.19% compared to head (d50521b) 87.19%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2947   +/-   ##
========================================
  Coverage    87.19%   87.19%           
========================================
  Files          860      860           
  Lines        29326    29327    +1     
  Branches      6845     6845           
========================================
+ Hits         25570    25571    +1     
  Misses        3410     3410           
  Partials       346      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ItsSudip · 2024-01-04T06:30:54Z

src/v0/destinations/google_adwords_enhanced_conversions/transform.js

@@ -77,6 +77,8 @@ const processTrackEvent = async (metadata, message, destination) => {
  const payload = constructPayload(message, updatedMapping);

  payload.partialFailure = true;
+  // ref: https://developers.google.com/google-ads/api/docs/release-notes#:~:text=Added%20job_id%20as,UploadConversionAdjustmentsRequest
+  payload.jobId = metadata.jobId;


Can't we support properties.jobId as well? Some customer might try to provide jobId from their own.
CC @shrouti1507 @krishna2020

can you tell what's the use-case of customer for providing jobId when destination has ability to generate jobId in case of null ?

Customer can maintain some unique numbers on their database and send that as jobId.

sonarqubecloud · 2024-01-04T06:35:34Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

krishna2020 · 2024-01-04T08:13:13Z

src/v0/destinations/google_adwords_enhanced_conversions/transform.js

@@ -77,6 +77,8 @@ const processTrackEvent = async (metadata, message, destination) => {
  const payload = constructPayload(message, updatedMapping);

  payload.partialFailure = true;
+  // ref: https://developers.google.com/google-ads/api/docs/release-notes#:~:text=Added%20job_id%20as,UploadConversionAdjustmentsRequest
+  payload.jobId = metadata.jobId;


@shrouti1507 There's no point of introducing jobId in this PR without handling partial failure feature

krishna2020 · 2024-01-04T10:21:34Z

Restrict the PR only to version upgrade changes & create separate task for jobId field support

shrouti1507 · 2024-01-04T10:32:26Z

for now we are just adding support for v15 at #2966

fix: enhancement and version upgrade of gaec

940b756

shrouti1507 added the enhancement New feature or request label Dec 21, 2023

shrouti1507 self-assigned this Dec 21, 2023

shrouti1507 requested review from a team and sivashanmukh as code owners December 21, 2023 12:26

shrouti1507 requested review from aashishmalik and ujjwal-ab December 21, 2023 12:26

shrouti1507 changed the title ~~fix: enhancement and version upgrade of gaec~~ fix: enhancement and version upgrade of google adwords enhanced conversion Dec 21, 2023

koladilip approved these changes Dec 21, 2023

View reviewed changes

koladilip previously approved these changes Dec 21, 2023

View reviewed changes

Merge branch 'develop' into enhance.gaec

2c1a71b

ItsSudip previously approved these changes Dec 26, 2023

View reviewed changes

fix: added metadata.jobId to jobId of the payload

74a2be7

shrouti1507 dismissed stale reviews from ItsSudip and koladilip via 74a2be7 January 4, 2024 05:54

Merge branch 'develop' into enhance.gaec

d1240de

shrouti1507 requested review from ItsSudip, koladilip and krishna2020 and removed request for ujjwal-ab January 4, 2024 05:54

koladilip approved these changes Jan 4, 2024

View reviewed changes

Merge branch 'develop' into enhance.gaec

d50521b

ItsSudip reviewed Jan 4, 2024

View reviewed changes

krishna2020 reviewed Jan 4, 2024

View reviewed changes

shrouti1507 closed this Jan 4, 2024

devops-github-rudderstack deleted the enhance.gaec branch April 5, 2024 01:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: enhancement and version upgrade of google adwords enhanced conversion #2947

fix: enhancement and version upgrade of google adwords enhanced conversion #2947

shrouti1507 commented Dec 21, 2023 •

edited

Loading

coderabbitai bot commented Dec 21, 2023 •

edited

Loading

Auto Review Skipped

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

codecov bot commented Dec 21, 2023 •

edited

Loading

ItsSudip Jan 4, 2024

krishna2020 Jan 4, 2024 •

edited

Loading

ItsSudip Jan 4, 2024

sonarqubecloud bot commented Jan 4, 2024

krishna2020 Jan 4, 2024 •

edited

Loading

krishna2020 commented Jan 4, 2024

shrouti1507 commented Jan 4, 2024

fix: enhancement and version upgrade of google adwords enhanced conversion #2947

fix: enhancement and version upgrade of google adwords enhanced conversion #2947

Conversation

shrouti1507 commented Dec 21, 2023 • edited Loading

What are the changes introduced in this PR?

Please explain the objectives of your changes below

Type of change

Any technical or performance related pointers to consider with the change?

Any new dependencies introduced with this change?

Any new generic utility introduced or modified. Please explain the changes.

If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.

If multiple linear tasks are associated with the PR changes, please elaborate on the reason:

Developer checklist

Reviewer checklist

coderabbitai bot commented Dec 21, 2023 • edited Loading

Auto Review Skipped

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

codecov bot commented Dec 21, 2023 • edited Loading

Codecov Report

ItsSudip Jan 4, 2024

Choose a reason for hiding this comment

krishna2020 Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

ItsSudip Jan 4, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 4, 2024

Quality Gate passed

krishna2020 Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

krishna2020 commented Jan 4, 2024

shrouti1507 commented Jan 4, 2024

shrouti1507 commented Dec 21, 2023 •

edited

Loading

coderabbitai bot commented Dec 21, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Dec 21, 2023 •

edited

Loading

krishna2020 Jan 4, 2024 •

edited

Loading

krishna2020 Jan 4, 2024 •

edited

Loading