Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhancement and version upgrade of google adwords offline conversion #2946

Closed
wants to merge 7 commits into from

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Dec 21, 2023

What are the changes introduced in this PR?

resolves INT-1309

This PR is divided into destination level changes

Google has got a new API version 15. We are updating API version of

Google adwords offline conversion

Also we are adding support of the new fields added by google for this above destination

Doc references :

offline conversion

click conversion adding consent support https://developers.google.com/google-ads/api/reference/rpc/v15/ClickConversion#consent

call conversion https://developers.google.com/google-ads/api/reference/rpc/v15/CallConversion#consent

store sales consent https://developers.google.com/google-ads/api/reference/rpc/v15/UserData#consent

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Type of change

enhancement

  • Existing capabilities/behavior

No change

  • New capabilities/behavior

added consent field support for all of the three types of conversions

Any technical or performance related pointers to consider with the change?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.

N/A

If multiple linear tasks are associated with the PR changes, please elaborate on the reason:

N/A


Developer checklist

  • No breaking changes are being introduced.

  • Are all related docs linked with the PR?

  • Are all changes manually tested?

  • Does this change require any documentation changes?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 added the enhancement New feature or request label Dec 21, 2023
@shrouti1507 shrouti1507 self-assigned this Dec 21, 2023
@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners December 21, 2023 12:01
Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file
    • @coderabbitai modularize this function
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai gather interesting statistics about this repository and render them in a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (429ca71) 87.18% compared to head (df63d5e) 87.18%.
Report is 66 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2946   +/-   ##
========================================
  Coverage    87.18%   87.18%           
========================================
  Files          860      861    +1     
  Lines        29303    29320   +17     
  Branches      6836     6843    +7     
========================================
+ Hits         25547    25564   +17     
  Misses        3410     3410           
  Partials       346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/v0/util/index.js Outdated Show resolved Hide resolved
Copy link

@shrouti1507 shrouti1507 added the DO NOT MERGE Don't merge this PR without having discussion label Jan 5, 2024
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion enhancement New feature or request Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants