-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhancement and version upgrade of google adwords offline conversion #2946
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2946 +/- ##
========================================
Coverage 87.18% 87.18%
========================================
Files 860 861 +1
Lines 29303 29320 +17
Branches 6836 6843 +7
========================================
+ Hits 25547 25564 +17
Misses 3410 3410
Partials 346 346 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
What are the changes introduced in this PR?
resolves INT-1309
This PR is divided into destination level changes
Google has got a new API version 15. We are updating API version of
Google adwords offline conversion
Also we are adding support of the new fields added by google for this above destination
Doc references :
offline conversion
click conversion adding consent support https://developers.google.com/google-ads/api/reference/rpc/v15/ClickConversion#consent
call conversion https://developers.google.com/google-ads/api/reference/rpc/v15/CallConversion#consent
store sales consent https://developers.google.com/google-ads/api/reference/rpc/v15/UserData#consent
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Type of change
enhancement
No change
added consent field support for all of the three types of conversions
Any technical or performance related pointers to consider with the change?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.
N/A
If multiple linear tasks are associated with the PR changes, please elaborate on the reason:
N/A
Developer checklist
No breaking changes are being introduced.
Are all related docs linked with the PR?
Are all changes manually tested?
Does this change require any documentation changes?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.