Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added adwords test for v1 proxy #2919

Closed
wants to merge 2 commits into from
Closed

chore: added adwords test for v1 proxy #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd3513
fix: inclusion of right status-code & error details in proxy response
Dec 14, 2023
8c8cc74
chore: added adwords test for v1 proxy
aashishmalik Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/controllers/delivery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export class DeliveryController {
);
}
ctx.body = { output: deliveryResponse };
ControllerUtility.deliveryPostProcess(ctx);
ControllerUtility.deliveryPostProcess(ctx, deliveryResponse.status);

logger.debug('Native(Delivery):: Response from transformer::', JSON.stringify(ctx.body));
return ctx;
Expand Down
3 changes: 3 additions & 0 deletions src/services/destination/nativeIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,9 @@ export class NativeIntegrationDestinationService implements DestinationService {
);
responseProxy = {
response: jobStates,
status: v0Response.status,
message: v0Response.message,
authErrorCategory: v0Response.authErrorCategory,
} as DeliveriesResponse;
}
return responseProxy;
Expand Down
1 change: 1 addition & 0 deletions src/services/destination/postTransformation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ export class DestinationPostTransformationService {
statTags: errObj.statTags,
authErrorCategory: errObj.authErrorCategory,
message: errObj.message.toString(),
status: error.status,
} as DeliveriesResponse;

ErrorReportingService.reportError(error, metaTo.errorContext, resp);
Expand Down
8 changes: 6 additions & 2 deletions test/integrations/destinations/braze/dataDelivery/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ export const data = [
status: 200,
body: {
output: {
message: 'Request for braze Processed Successfully',
response: [
{
error: '{"aliases_processed":1,"message":"success"}',
Expand All @@ -563,6 +564,7 @@ export const data = [
},
},
],
status: 201,
},
},
},
Expand Down Expand Up @@ -627,9 +629,10 @@ export const data = [
},
output: {
response: {
status: 200,
status: 401,
body: {
output: {
status: 401,
response: [
{
error: '{"code":400,"message":"Bad Req","status":"Fail Case"}',
Expand Down Expand Up @@ -767,9 +770,10 @@ export const data = [
},
output: {
response: {
status: 200,
status: 401,
body: {
output: {
status: 401,
response: [
{
error:
Expand Down
Loading
Loading