Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: braze transformation error due to wrong import #2901

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Dec 13, 2023

What are the changes introduced in this PR?

In FilteredEventsError , we are using BaseError from src/v0/util/errorTypes/base.js
And in generateErrorObject we are using instanceof on BaseError from integrations-lib. Hence instanceof condition is failing & no matter what specific errorCategory is provided in the error, it is getting converted to transformation errorCategory.

This PR aims to fix this inconsistency

Resolves INT-1187

Please explain the objectives of your changes below

  • We have also fixed the import problem in TransformerProxyError class as well
  • Used ?. optional-chaining for evaluating if features contains filterCode feature

Type of change

If the pull request is a bug-fix, enhancement or a refactor, please fill in the details on the changes made.

  • Existing capabilities/behavior

  • New capabilities/behavior

If the pull request is a new feature,

Any technical or performance related pointers to consider with the change?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.

N/A

If multiple linear tasks are associated with the PR changes, please elaborate on the reason:

N/A


Developer checklist

  • No breaking changes are being introduced.

  • Are all related docs linked with the PR?

  • Are all changes manually tested?

  • Does this change require any documentation changes?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 self-assigned this Dec 13, 2023
@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners December 13, 2023 04:47
Copy link
Contributor

coderabbitai bot commented Dec 13, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@sanpj2292 sanpj2292 changed the base branch from develop to release/v1.52.0 December 13, 2023 04:47
@@ -841,9 +841,7 @@
},
{
"error": "[Braze Deduplication]: Duplicate user detected, the user is dropped",
"statTags": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had test case too to validate the previous change then !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 🙁

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be20850) 87.27% compared to head (03cdb16) 87.28%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.52.0    #2901   +/-   ##
================================================
  Coverage            87.27%   87.28%           
================================================
  Files                  791      790    -1     
  Lines                29218    29206   -12     
  Branches              6834     6828    -6     
================================================
- Hits                 25501    25491   -10     
+ Misses                3373     3371    -2     
  Partials               344      344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sanpj2292 sanpj2292 merged commit 90c725e into release/v1.52.0 Dec 13, 2023
18 checks passed
@sanpj2292 sanpj2292 deleted the fix.braze-tf-error branch December 13, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants