-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: braze transformation error due to wrong import #2901
Conversation
Signed-off-by: Sai Sankeerth <[email protected]>
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
@@ -841,9 +841,7 @@ | |||
}, | |||
{ | |||
"error": "[Braze Deduplication]: Duplicate user detected, the user is dropped", | |||
"statTags": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had test case too to validate the previous change then !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 🙁
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.52.0 #2901 +/- ##
================================================
Coverage 87.27% 87.28%
================================================
Files 791 790 -1
Lines 29218 29206 -12
Branches 6834 6828 -6
================================================
- Hits 25501 25491 -10
+ Misses 3373 3371 -2
Partials 344 344 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What are the changes introduced in this PR?
In
FilteredEventsError
, we are usingBaseError
fromsrc/v0/util/errorTypes/base.js
And in
generateErrorObject
we are usinginstanceof
onBaseError
fromintegrations-lib
. Henceinstanceof
condition is failing & no matter what specific errorCategory is provided in the error, it is getting converted totransformation
errorCategory.This PR aims to fix this inconsistency
Resolves INT-1187
Please explain the objectives of your changes below
TransformerProxyError
class as well?.
optional-chaining for evaluating if features contains filterCode featureType of change
If the pull request is a bug-fix, enhancement or a refactor, please fill in the details on the changes made.
Existing capabilities/behavior
New capabilities/behavior
If the pull request is a new feature,
Any technical or performance related pointers to consider with the change?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.
N/A
If multiple linear tasks are associated with the PR changes, please elaborate on the reason:
N/A
Developer checklist
No breaking changes are being introduced.
Are all related docs linked with the PR?
Are all changes manually tested?
Does this change require any documentation changes?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.