Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/v1.52.0 into main #2898

Merged
merged 29 commits into from
Dec 13, 2023
Merged

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

utsabc and others added 23 commits December 6, 2023 17:15
chore: add stats for shopify anonId resolution based on shopifyTopic and method
…lers (#2868)

Add workspaceId in common metadata to be returned to the callers
* feat: onboard reddit cloud mode destination

* feat: update mappings

* feat: add event_type support

* feat: add batching support

* feat: add reddit to features.json

* feat: refactor code

* fix: add check for empty string in eventName

* fix: use generic mapping for timestamp

* chore: add test cases

* fix: refactor code

* fix: refactor code

* feat: add networkHandler

* feat: refactor networkHandler

* chore: add delivery tests

* fix: add additional check for accessToken failure

* fix: remove extra parameter from retryable error
…nversion (#2860)

* fix: removed retry logic from v1 cm360 proxy handler

* feat: adapter to convert v1 payload to v0 transformer Proxy
* feat: onboard msl changes for new record event

* chore: remove older tc for MSL

* fix: metadata

* fix: metadatax2

* chore: address comments

* chore: address commentsx2, handle mix of audiencelist and record events

* chore: address commentsx2, handle mix of audiencelist and record events

* chore: add router test

* fix: record to audience handling (#2813)

* fix: unit case with empty request

* fix: missed error lib

* chore: refactor tests

* refactor: address comments

* chore: address commentsx2

* fix: error message, handle metadata, missing id

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
* chore: init onboard

* chore: add network handler

* chore: add test

* fix: adding correct mock with corrections & modify the status-code in test-case

Signed-off-by: Sai Sankeerth <[email protected]>

* chore: add dummy destination id

* chore: add dummy ws id

* chore: add tests for success and generic error case

---------

Signed-off-by: Sai Sankeerth <[email protected]>
Co-authored-by: Sai Sankeerth <[email protected]>
* fix(integrations): onboard sprig destination

* chore: code review changes

* chore: code review changes
When message doesn't contain event field there is no meaningful
process we can do so considering it as instrumenation error.
#2897)

Found logs for this error:
Failure occurred during custom attributes operations
TypeError: Cannot read properties of null (reading 'update')
mailjet code uses md5 method to hash email for using it as userId
when actual userId is not found in the event and when email doesn't
exists then md5 throwing an error so added check before calling
md5 method.
* fix: covert toString before toLowercase

* fix: throw error if not valid email
* feat: tiktok_ads: add support for custom events

* chore: added doc link
* fix: send response object captured after API call to active_campaign error handler

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: add test-cases for 5xx, 4xx failures

Signed-off-by: Sai Sankeerth <[email protected]>

---------

Signed-off-by: Sai Sankeerth <[email protected]>
Co-authored-by: Sai Sankeerth <[email protected]>
Copy link
Contributor

coderabbitai bot commented Dec 12, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (981bae8) 87.19% compared to head (a606ec1) 87.27%.

Files Patch % Lines
src/v0/destinations/active_campaign/transform.js 12.50% 14 Missing ⚠️
src/controllers/delivery.ts 57.69% 11 Missing ⚠️
src/v0/util/errorTypes/transformerProxyError.js 35.71% 6 Missing and 3 partials ⚠️
...c/v0/destinations/marketo_static_list/transform.js 88.37% 5 Missing ⚠️
...v0/destinations/marketo_static_list/transformV2.js 92.53% 5 Missing ⚠️
src/services/delivertTest/deliveryTest.ts 0.00% 3 Missing ⚠️
src/services/destination/postTransformation.ts 81.25% 3 Missing ⚠️
src/util/openfaas/index.js 87.50% 1 Missing ⚠️
src/v0/destinations/adobe_analytics/utils.js 50.00% 1 Missing ⚠️
src/v0/destinations/reddit/networkHandler.js 96.15% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
+ Coverage   87.19%   87.27%   +0.07%     
==========================================
  Files         776      790      +14     
  Lines       28943    29208     +265     
  Branches     6791     6830      +39     
==========================================
+ Hits        25237    25491     +254     
- Misses       3364     3373       +9     
- Partials      342      344       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abhimanyubabbar and others added 6 commits December 12, 2023 19:34
* dropped support of useClones for trackingplans cache

* updated the changelog
* chore: add lowercase check to MSL for event type audiencelist

* chore: fix optional chaining

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: update test

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
feat: add undefined check for evensMapping field
Copy link

@krishna2020 krishna2020 merged commit 045f362 into main Dec 13, 2023
16 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the release/v1.52.0 branch December 13, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.