fix: active_campaign error handler #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error handler Signed-off-by: Sai Sankeerth <[email protected]>
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2895 +/- ##
===========================================
+ Coverage 87.25% 87.28% +0.02%
===========================================
Files 791 791
Lines 29195 29214 +19
Branches 6832 6832
===========================================
+ Hits 25473 25498 +25
+ Misses 3377 3372 -5
+ Partials 345 344 -1 ☔ View full report in Codecov by Sentry. |
yashasvibajpai
previously approved these changes
Dec 12, 2023
koladilip
previously approved these changes
Dec 12, 2023
Signed-off-by: Sai Sankeerth <[email protected]>
sanpj2292
dismissed stale reviews from koladilip and yashasvibajpai
via
a0a0f78
…to fix.ac-error-handling
yashasvibajpai
approved these changes
Dec 12, 2023
|
Kudos, SonarCloud Quality Gate passed! |
utsabc
reviewed
Dec 12, 2023
koladilip
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Whenever there are node errors like EAI_AGAIN, ECONNABORTED etc,. the error handler is not able to handle the error properly.
Through this PR we aim to fix it.
Resolves INT-1157
Please explain the objectives of your changes below
N/A
Type of change
If the pull request is a bug-fix, enhancement or a refactor, please fill in the details on the changes made.
If the pull request is a new feature,
Any technical or performance related pointers to consider with the change?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.
N/A
If multiple linear tasks are associated with the PR changes, please elaborate on the reason:
N/A
Developer checklist
No breaking changes are being introduced.
Are all related docs linked with the PR?
Are all changes manually tested?
Does this change require any documentation changes?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.