Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove errorCategory for braze dedup error #2850

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Nov 23, 2023

Description of the change

Remove unnecessary errorCategory in braze

Resolves INT-964

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

INT-964

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Summary by CodeRabbit

  • Refactor
    • Simplified error handling by removing unnecessary tagging in FilteredEventsError.

@sanpj2292 sanpj2292 self-assigned this Nov 23, 2023
@sanpj2292 sanpj2292 requested a review from a team as a code owner November 23, 2023 13:07
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9eda50e) 87.16% compared to head (8f6a72c) 87.17%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2850   +/-   ##
========================================
  Coverage    87.16%   87.17%           
========================================
  Files          772      772           
  Lines        28788    28786    -2     
  Branches      6764     6764           
========================================
- Hits         25094    25093    -1     
+ Misses        3351     3350    -1     
  Partials       343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The change simplifies error handling in a JavaScript class by removing unnecessary code. Specifically, it eliminates the import of an unused module and the creation of an object that was not utilized. The FilteredEventsError class is streamlined to only call its parent class constructor with the necessary arguments, making the code cleaner and more efficient.

Changes

File Path Change Summary
src/v0/util/errorTypes/filteredEventsError.js Removed import of tags module and finalStatTags object; updated constructor to call parent class directly.

Poem

In the burrow of the code, a cleanup was due,
🐇 CodeRabbit hopped in, with a refactor or two.
No more clutter or unused tags in sight,
Just sleek, hopping code, running swift and light.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9eda50e and 8f6a72c.
Files selected for processing (1)
  • src/v0/util/errorTypes/filteredEventsError.js (1 hunks)
Additional comments: 1
src/v0/util/errorTypes/filteredEventsError.js (1)
  • 4-8: The changes to the FilteredEventsError class constructor are correct and align with the summary provided. The constructor now directly calls the parent class constructor with the message and statusCode.

@sanpj2292 sanpj2292 merged commit 91d4cd1 into develop Nov 29, 2023
6 checks passed
@sanpj2292 sanpj2292 deleted the fix.braze-gen-tf-error branch November 29, 2023 07:24
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants