-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove errorCategory for braze dedup error #2850
Conversation
Signed-off-by: Sai Sankeerth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2850 +/- ##
========================================
Coverage 87.16% 87.17%
========================================
Files 772 772
Lines 28788 28786 -2
Branches 6764 6764
========================================
- Hits 25094 25093 -1
+ Misses 3351 3350 -1
Partials 343 343 ☔ View full report in Codecov by Sentry. |
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe change simplifies error handling in a JavaScript class by removing unnecessary code. Specifically, it eliminates the import of an unused module and the creation of an object that was not utilized. The Changes
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/v0/util/errorTypes/filteredEventsError.js (1 hunks)
Additional comments: 1
src/v0/util/errorTypes/filteredEventsError.js (1)
- 4-8: The changes to the
FilteredEventsError
class constructor are correct and align with the summary provided. The constructor now directly calls the parent class constructor with themessage
andstatusCode
.
Kudos, SonarCloud Quality Gate passed! |
Description of the change
Remove unnecessary errorCategory in braze
Resolves INT-964
Type of change
Related issues
INT-964
Checklists
Development
Code review
Summary by CodeRabbit
FilteredEventsError
.