Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugsnag issue in sfmc for track events #2846

Closed
wants to merge 1 commit into from

Conversation

sanpj2292
Copy link
Contributor

Description of the change

When sending track event without event, we are getting an internal server error. Through this PR we are looking to fix it.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sanpj2292 sanpj2292 self-assigned this Nov 22, 2023
@sanpj2292 sanpj2292 requested review from a team as code owners November 22, 2023 09:30
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c63d2c) 87.15% compared to head (d11ac84) 87.15%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2846   +/-   ##
========================================
  Coverage    87.15%   87.15%           
========================================
  Files          772      772           
  Lines        28745    28746    +1     
  Branches      6753     6753           
========================================
+ Hits         25052    25053    +1     
  Misses        3350     3350           
  Partials       343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sanpj2292 sanpj2292 mentioned this pull request Nov 27, 2023
10 tasks
@sanpj2292
Copy link
Contributor Author

Closing this PR as we already have #2852 already covering all possible scenarios

@sanpj2292 sanpj2292 closed this Nov 28, 2023
@sanpj2292 sanpj2292 deleted the fix.bugsnag-sfmc branch December 14, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants